From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH 05/10] tpm: tpm_tis: Add post_probe phy handler Date: Mon, 11 Apr 2016 14:22:27 -0600 Message-ID: <20160411202227.GB3357@obsidianresearch.com> References: <1460323386-16892-1-git-send-email-christophe-h.ricard@st.com> <1460323386-16892-6-git-send-email-christophe-h.ricard@st.com> <20160410234333.GB11226@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160410234333.GB11226-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Christophe Ricard Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, jean-luc.blanc-qxv4g6HH51o@public.gmane.org, ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org, benoit.houyere-qxv4g6HH51o@public.gmane.org, christophe-h.ricard-qxv4g6HH51o@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Sun, Apr 10, 2016 at 05:43:33PM -0600, Jason Gunthorpe wrote: > On Sun, Apr 10, 2016 at 11:23:01PM +0200, Christophe Ricard wrote: > > > +static int tpm_tis_post_probe(struct tpm_chip *chip) > > +{ > > + int probe; > > + > > + if (!itpm) { > > Please get rid of the itpm global while you are at it. Sorry, I keep forgetting this ugly thing is a module option. Sigh. Jason ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z