From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Jarkko Sakkinen
<jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: "moderated list:TPM DEVICE DRIVER"
<tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] tpm: fix crash in tpm_tis deinitialization
Date: Tue, 12 Apr 2016 11:26:55 -0600 [thread overview]
Message-ID: <20160412172655.GA5759@obsidianresearch.com> (raw)
In-Reply-To: <20160412042627.GA6608-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Tue, Apr 12, 2016 at 07:26:27AM +0300, Jarkko Sakkinen wrote:
> > This needs to be after ops is fenced, something like this.
>
> I would appreciate a supporting argument.
>
> I guess the argument here is that this will prevent user space from
> issuing TPM commands after the shutdown command has been sent?
It prevents everything including the kernel from issuing a command
after shutdown. The shutdown is sent as the last command and no other
commands can follow it.
It doesn't make any sense to allow commands to follow shutdown.
Jason
------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
next prev parent reply other threads:[~2016-04-12 17:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 16:05 [PATCH] tpm: fix crash in tpm_tis deinitialization Jarkko Sakkinen
[not found] ` <1460390720-9509-1-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-04-11 17:40 ` Jason Gunthorpe
[not found] ` <20160411174037.GA371-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-04-12 4:26 ` Jarkko Sakkinen
[not found] ` <20160412042627.GA6608-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-04-12 17:26 ` Jason Gunthorpe [this message]
[not found] ` <20160412172655.GA5759-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-04-13 6:16 ` Jarkko Sakkinen
2016-04-13 6:58 ` Jarkko Sakkinen
[not found] ` <20160413065805.GB6986-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-04-13 17:04 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160412172655.GA5759@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).