From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v2 11/12] tpm/tpm_tis: Split tpm_tis driver into a core and TCG TIS compliant phy Date: Wed, 13 Apr 2016 14:48:42 -0600 Message-ID: <20160413204842.GD3836@obsidianresearch.com> References: <1460577351-24632-1-git-send-email-christophe-h.ricard@st.com> <1460577351-24632-12-git-send-email-christophe-h.ricard@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1460577351-24632-12-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Christophe Ricard Cc: jean-luc.blanc-qxv4g6HH51o@public.gmane.org, ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, christophe-h.ricard-qxv4g6HH51o@public.gmane.org, Peter Huewe , benoit.houyere-qxv4g6HH51o@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Wed, Apr 13, 2016 at 09:55:50PM +0200, Christophe Ricard wrote: > +EXPORT_SYMBOL_GPL(release_locality); All exports need better names to avoid namespace collisions. tpm_tis_release_locatity perhaps? > +SIMPLE_DEV_PM_OPS(tpm_tis_pm, tpm_pm_suspend, tpm_tis_resume); > +EXPORT_SYMBOL_GPL(tpm_tis_pm); Hum, not sure that is a good idea... That stuff should probably be in each driver? > @@ -52,7 +106,6 @@ struct tpm_tis_data { > const struct tpm_tis_class_lowlevel *lowlevel; > const struct tpm_tis_phy_ops *phy_ops; > void *phy_id; > - int (*post_probe)(struct tpm_chip *chip); Please clean up your patches so rebase mistakes like this are not included. Jason ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z