From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: 0001-added-tpm-2.0-support-to-nuvoton-i2c-driver.patch Date: Tue, 19 Apr 2016 13:02:03 +0300 Message-ID: <20160419100203.GB10080@intel.com> References: <20160419050442.7048840F8@taln70.nuvoton.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <20160419050442.7048840F8-1UdtCKOZWuXOzY7siszIiwMMGMOHi2eC@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: "Andrew Zamansky (NTIL)" Cc: shmulik.hager-KrzQf0k3Iz9BDgjK7y7TUQ@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, gcwilson-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org, dan.morav-KrzQf0k3Iz9BDgjK7y7TUQ@public.gmane.org, --@taln70.nuvoton.co.il List-Id: tpmdd-devel@lists.sourceforge.net On Tue, Apr 19, 2016 at 08:04:42AM +0300, Andrew Zamansky (NTIL) wrote: > >From b1503617a4c2b89f5a366a3d38b303b5de606c59 Mon Sep 17 00:00:00 2001 > From: andrew azmansky > Date: Thu, 7 Apr 2016 09:19:57 +0300 > Subject: [PATCH 1/1] added tpm 2.0 support to nuvoton i2c driver > = > add tpm 2.0 support to nuvoton i2c tpm driver > = > Signed-off-by: andrew azmansky https://www.kernel.org/doc/Documentation/SubmittingPatches /Jarkko > --- > .../devicetree/bindings/i2c/trivial-devices.txt | 1 + > drivers/char/tpm/tpm_i2c_nuvoton.c | 25 ++++++++++++++++= +++--- > 2 files changed, 23 insertions(+), 3 deletions(-) > = > diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/= Documentation/devicetree/bindings/i2c/trivial-devices.txt > index 53987449..0a07cbc 100644 > --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt > +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt > @@ -62,6 +62,7 @@ national,lm80 Serial Interface ACPI-Compatible = Microprocessor System Hardware M > national,lm85 Temperature sensor with integrated fan control > national,lm92 =B10.33=B0C Accurate, 12-Bit + Sign Temperature S= ensor and Thermal Window Comparator with Two-Wire Interface > nuvoton,npct501 i2c trusted platform module (TPM) > +nuvoton,npct6xx i2c trusted platform module (TPM) 6xx ser= ies > nxp,pca9556 Octal SMBus and I2C registered interface > nxp,pca9557 8-bit I2C-bus and SMBus I/O port with reset > nxp,pcf8563 Real-time clock/calendar > diff --git a/drivers/char/tpm/tpm_i2c_nuvoton.c b/drivers/char/tpm/tpm_i2= c_nuvoton.c > index 847f159..215a2b4 100644 > --- a/drivers/char/tpm/tpm_i2c_nuvoton.c > +++ b/drivers/char/tpm/tpm_i2c_nuvoton.c > @@ -1,5 +1,5 @@ > /***********************************************************************= ******* > - * Nuvoton TPM I2C Device Driver Interface for WPCT301/NPCT501, > + * Nuvoton TPM I2C Device Driver Interface for WPCT301/NPCT501/NPCT6XX, > * based on the TCG TPM Interface Spec version 1.2. > * Specifications at www.trustedcomputinggroup.org > * > @@ -163,7 +163,7 @@ static int i2c_nuvoton_get_burstcount(struct i2c_clie= nt *client, > } > = > /* > - * WPCT301/NPCT501 SINT# supports only dataAvail > + * WPCT301/NPCT501/NPCT6XX SINT# supports only dataAvail > * any call to this function which is not waiting for dataAvail will > * set queue to NULL to avoid waiting for interrupt > */ > @@ -601,10 +601,28 @@ static int i2c_nuvoton_probe(struct i2c_client *cli= ent, > } > } > = > + rc =3D tpm2_probe(chip); > + if (rc) > + return rc; > + > if (tpm_get_timeouts(chip)) > return -ENODEV; > = > - if (tpm_do_selftest(chip)) > + if (chip->flags & TPM_CHIP_FLAG_TPM2) { > + > + rc =3D tpm2_do_selftest(chip); > + if (rc =3D=3D TPM2_RC_INITIALIZE) { > + if (tpm2_startup(chip, TPM2_SU_CLEAR)) > + return -ENODEV; > + > + rc =3D tpm2_do_selftest(chip); > + } > + > + } else { > + rc =3D tpm_do_selftest(chip); > + } > + > + if (rc) > return -ENODEV; > = > return tpm_chip_register(chip); > @@ -628,6 +646,7 @@ MODULE_DEVICE_TABLE(i2c, i2c_nuvoton_id); > static const struct of_device_id i2c_nuvoton_of_match[] =3D { > {.compatible =3D "nuvoton,npct501"}, > {.compatible =3D "winbond,wpct301"}, > + {.compatible =3D "nuvoton,npct6xx"}, > {}, > }; > MODULE_DEVICE_TABLE(of, i2c_nuvoton_of_match); > -- > 1.9.1 > = > = > = > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > The privileged confidential information contained in this email is intend= ed for use only by the addressees as indicated by the original sender of th= is email. If you are not the addressee indicated in this email or are not r= esponsible for delivery of the email to such a person, please kindly reply = to the sender indicating this fact and delete all copies of it from your co= mputer and network server immediately. Your cooperation is highly appreciat= ed. It is advised that any unauthorized use of confidential information of = Nuvoton is strictly prohibited; and any information in this email irrelevan= t to the official business of Nuvoton shall be deemed as neither given nor = endorsed by Nuvoton. > = > -------------------------------------------------------------------------= ----- > Find and fix application performance issues faster with Applications Mana= ger > Applications Manager provides deep performance insights into multiple tie= rs of > your business applications. It resolves application problems quickly and > reduces your MTTR. Get your free trial! > https://ad.doubleclick.net/ddm/clk/302982198;130105516;z > _______________________________________________ > tpmdd-devel mailing list > tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org > https://lists.sourceforge.net/lists/listinfo/tpmdd-devel ---------------------------------------------------------------------------= --- Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers= of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z