From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v4 04/12] tpm_tis: Introduce intermediate layer for TPM access Date: Tue, 19 Apr 2016 11:39:34 -0600 Message-ID: <20160419173934.GA26460@obsidianresearch.com> References: <1461017864-3903-1-git-send-email-christophe-h.ricard@st.com> <1461017864-3903-5-git-send-email-christophe-h.ricard@st.com> <20160419130747.GC4796@intel.com> <20160419171625.GA11619@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160419171625.GA11619-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jarkko Sakkinen Cc: Christophe Ricard , "ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org" , Jean-Luc BLANC , "tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , Christophe RICARD , Benoit HOUYERE List-Id: tpmdd-devel@lists.sourceforge.net On Tue, Apr 19, 2016 at 08:16:25PM +0300, Jarkko Sakkinen wrote: > On Tue, Apr 19, 2016 at 03:20:25PM +0200, Christophe Ricard wrote: > > Hi Jarkko, > > > > Do you thing tpm_tis.c should be renamed tpm_tis_tcg.c as well ? > > Yeah. > > I would structure things like this: > > * tpm_tis.ko (core stuff) > * tpm_tis_tcg.ko > * tpm_tis_spi.ko > * ... No. We shouldn't change the module name for the LPC driver, that breaks the uAPI in a visible way. Jason ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z