From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Cc: Christophe Ricard
<christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org"
<ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org>,
Jean-Luc BLANC <jean-luc.blanc-qxv4g6HH51o@public.gmane.org>,
"tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
<tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
Christophe RICARD
<christophe-h.ricard-qxv4g6HH51o@public.gmane.org>,
Benoit HOUYERE <benoit.houyere-qxv4g6HH51o@public.gmane.org>
Subject: Re: [PATCH v4 04/12] tpm_tis: Introduce intermediate layer for TPM access
Date: Tue, 19 Apr 2016 21:56:05 +0300 [thread overview]
Message-ID: <20160419185605.GB13115@intel.com> (raw)
In-Reply-To: <20160419173934.GA26460-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
On Tue, Apr 19, 2016 at 11:39:34AM -0600, Jason Gunthorpe wrote:
> On Tue, Apr 19, 2016 at 08:16:25PM +0300, Jarkko Sakkinen wrote:
> > On Tue, Apr 19, 2016 at 03:20:25PM +0200, Christophe Ricard wrote:
> > > Hi Jarkko,
> > >
> > > Do you thing tpm_tis.c should be renamed tpm_tis_tcg.c as well ?
> >
> > Yeah.
> >
> > I would structure things like this:
> >
> > * tpm_tis.ko (core stuff)
> > * tpm_tis_tcg.ko
> > * tpm_tis_spi.ko
> > * ...
>
> No. We shouldn't change the module name for the LPC driver, that
> breaks the uAPI in a visible way.
Right. Lets keep the filename also as tpm_tis.c then...
> Jason
/Jarkko
------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
next prev parent reply other threads:[~2016-04-19 18:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 22:17 [PATCH v4 00/12] Rework of tpm_tis to share common logic accross phy's (lpc/spi/-i2c-) Christophe Ricard
[not found] ` <1461017864-3903-1-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-04-18 22:17 ` [PATCH v4 01/12] tpm: Add include guards in tpm.h Christophe Ricard
2016-04-18 22:17 ` [PATCH v4 02/12] tpm: tpm_tis: Share common data between phys Christophe Ricard
[not found] ` <1461017864-3903-3-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-04-19 12:50 ` Jarkko Sakkinen
2016-04-18 22:17 ` [PATCH v4 03/12] tpm: tpm_tis: Rename priv_data structure tpm_tis_data Christophe Ricard
[not found] ` <1461017864-3903-4-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-04-19 12:54 ` Jarkko Sakkinen
2016-04-18 22:17 ` [PATCH v4 04/12] tpm_tis: Introduce intermediate layer for TPM access Christophe Ricard
[not found] ` <1461017864-3903-5-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-04-19 13:07 ` Jarkko Sakkinen
[not found] ` <20160419130747.GC4796-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-04-19 13:20 ` Christophe Ricard
[not found] ` <CALD+uuxbqVYrPxpAz2gZo5+5hu+Yagt4XkinJUXfZm3fztfKLw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-19 17:16 ` Jarkko Sakkinen
[not found] ` <20160419171625.GA11619-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-04-19 17:39 ` Jason Gunthorpe
[not found] ` <20160419173934.GA26460-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-04-19 18:56 ` Jarkko Sakkinen [this message]
[not found] ` <20160419185605.GB13115-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-04-19 19:14 ` Peter Huewe
2016-04-18 22:17 ` [PATCH v4 05/12] tpm_tis: Extend low-level interface to support proper return codes Christophe Ricard
2016-04-18 22:17 ` [PATCH v4 06/12] tpm: Manage itpm workaround with tis specific data_expect bit Christophe Ricard
2016-04-18 22:17 ` [PATCH v4 07/12] tpm: tpm_tis: Add post_probe phy handler Christophe Ricard
2016-04-18 22:17 ` [PATCH v4 08/12] devicetree: Add infineon to vendor-prefix.txt Christophe Ricard
2016-04-18 22:17 ` [PATCH v4 09/12] devicetree: Add Trusted Computing Group " Christophe Ricard
2016-04-18 22:17 ` [PATCH v4 10/12] tpm/tpm_tis: Split tpm_tis driver into a core and TCG TIS compliant phy Christophe Ricard
2016-04-18 22:17 ` [PATCH v4 11/12] tpm: Use read/write_bytes for drivers without more specialized methods Christophe Ricard
2016-04-18 22:17 ` [PATCH v4 12/12] tpm/tpm_tis_spi: Add support for spi phy Christophe Ricard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160419185605.GB13115@intel.com \
--to=jarkko.sakkinen-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org \
--cc=benoit.houyere-qxv4g6HH51o@public.gmane.org \
--cc=christophe-h.ricard-qxv4g6HH51o@public.gmane.org \
--cc=christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jean-luc.blanc-qxv4g6HH51o@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).