From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Stefan Berger <stefanb@linux.vnet.ibm.com>,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tpm: select ANON_INODES for proxy driver
Date: Fri, 29 Apr 2016 21:42:06 +0300 [thread overview]
Message-ID: <20160429184206.GA21071@intel.com> (raw)
In-Reply-To: <1461840382-2996256-1-git-send-email-arnd@arndb.de>
On Thu, Apr 28, 2016 at 12:46:13PM +0200, Arnd Bergmann wrote:
> The newly added vtpmx driver fails to build if CONFIG_ANON_INODES
> is disabled:
>
> drivers/char/built-in.o: In function `vtpmx_fops_ioctl':
> (.text+0x97f8): undefined reference to `anon_inode_getfile'
>
> This adds a Kconfig 'select' statement to ensure it's always there
> when we need it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 794c38e01358 ("tpm: Proxy driver for supporting multiple emulated TPMs")
Acked-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
> ---
> drivers/char/tpm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
> index 0eac596e33d1..bfdc5c0486aa 100644
> --- a/drivers/char/tpm/Kconfig
> +++ b/drivers/char/tpm/Kconfig
> @@ -125,6 +125,7 @@ config TCG_CRB
> config TCG_VTPM_PROXY
> tristate "VTPM Proxy Interface"
> depends on TCG_TPM
> + select ANON_INODES
> ---help---
> This driver proxies for an emulated TPM (vTPM) running in userspace.
> A device /dev/vtpmx is provided that creates a device pair
> --
> 2.7.0
>
next prev parent reply other threads:[~2016-04-29 18:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 10:46 [PATCH] tpm: select ANON_INODES for proxy driver Arnd Bergmann
[not found] ` <1461840382-2996256-1-git-send-email-arnd-r2nGTMty4D4@public.gmane.org>
2016-04-28 10:52 ` Stefan Berger
2016-04-29 18:42 ` Jarkko Sakkinen [this message]
[not found] ` <20160429184206.GA21071-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-04-29 19:41 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160429184206.GA21071@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=arnd@arndb.de \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=stefanb@linux.vnet.ibm.com \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).