* [PATCH] tpm: select ANON_INODES for proxy driver
@ 2016-04-28 10:46 Arnd Bergmann
[not found] ` <1461840382-2996256-1-git-send-email-arnd-r2nGTMty4D4@public.gmane.org>
2016-04-29 18:42 ` Jarkko Sakkinen
0 siblings, 2 replies; 4+ messages in thread
From: Arnd Bergmann @ 2016-04-28 10:46 UTC (permalink / raw)
To: Peter Huewe, Marcel Selhorst, Jarkko Sakkinen
Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Arnd Bergmann
The newly added vtpmx driver fails to build if CONFIG_ANON_INODES
is disabled:
drivers/char/built-in.o: In function `vtpmx_fops_ioctl':
(.text+0x97f8): undefined reference to `anon_inode_getfile'
This adds a Kconfig 'select' statement to ensure it's always there
when we need it.
Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Fixes: 794c38e01358 ("tpm: Proxy driver for supporting multiple emulated TPMs")
---
drivers/char/tpm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
index 0eac596e33d1..bfdc5c0486aa 100644
--- a/drivers/char/tpm/Kconfig
+++ b/drivers/char/tpm/Kconfig
@@ -125,6 +125,7 @@ config TCG_CRB
config TCG_VTPM_PROXY
tristate "VTPM Proxy Interface"
depends on TCG_TPM
+ select ANON_INODES
---help---
This driver proxies for an emulated TPM (vTPM) running in userspace.
A device /dev/vtpmx is provided that creates a device pair
--
2.7.0
------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
^ permalink raw reply related [flat|nested] 4+ messages in thread[parent not found: <1461840382-2996256-1-git-send-email-arnd-r2nGTMty4D4@public.gmane.org>]
* Re: [PATCH] tpm: select ANON_INODES for proxy driver
[not found] ` <1461840382-2996256-1-git-send-email-arnd-r2nGTMty4D4@public.gmane.org>
@ 2016-04-28 10:52 ` Stefan Berger
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Berger @ 2016-04-28 10:52 UTC (permalink / raw)
To: Arnd Bergmann, Peter Huewe, Marcel Selhorst, Jarkko Sakkinen
Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On 04/28/2016 06:46 AM, Arnd Bergmann wrote:
> The newly added vtpmx driver fails to build if CONFIG_ANON_INODES
> is disabled:
>
> drivers/char/built-in.o: In function `vtpmx_fops_ioctl':
> (.text+0x97f8): undefined reference to `anon_inode_getfile'
>
> This adds a Kconfig 'select' statement to ensure it's always there
> when we need it.
>
> Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
> Fixes: 794c38e01358 ("tpm: Proxy driver for supporting multiple emulated TPMs")
Acked-by: Stefan Berger <stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Thanks.
------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tpm: select ANON_INODES for proxy driver
2016-04-28 10:46 [PATCH] tpm: select ANON_INODES for proxy driver Arnd Bergmann
[not found] ` <1461840382-2996256-1-git-send-email-arnd-r2nGTMty4D4@public.gmane.org>
@ 2016-04-29 18:42 ` Jarkko Sakkinen
[not found] ` <20160429184206.GA21071-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
1 sibling, 1 reply; 4+ messages in thread
From: Jarkko Sakkinen @ 2016-04-29 18:42 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Peter Huewe, Marcel Selhorst, Jason Gunthorpe, Stefan Berger,
tpmdd-devel, linux-kernel
On Thu, Apr 28, 2016 at 12:46:13PM +0200, Arnd Bergmann wrote:
> The newly added vtpmx driver fails to build if CONFIG_ANON_INODES
> is disabled:
>
> drivers/char/built-in.o: In function `vtpmx_fops_ioctl':
> (.text+0x97f8): undefined reference to `anon_inode_getfile'
>
> This adds a Kconfig 'select' statement to ensure it's always there
> when we need it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 794c38e01358 ("tpm: Proxy driver for supporting multiple emulated TPMs")
Acked-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
> ---
> drivers/char/tpm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
> index 0eac596e33d1..bfdc5c0486aa 100644
> --- a/drivers/char/tpm/Kconfig
> +++ b/drivers/char/tpm/Kconfig
> @@ -125,6 +125,7 @@ config TCG_CRB
> config TCG_VTPM_PROXY
> tristate "VTPM Proxy Interface"
> depends on TCG_TPM
> + select ANON_INODES
> ---help---
> This driver proxies for an emulated TPM (vTPM) running in userspace.
> A device /dev/vtpmx is provided that creates a device pair
> --
> 2.7.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-29 19:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-28 10:46 [PATCH] tpm: select ANON_INODES for proxy driver Arnd Bergmann
[not found] ` <1461840382-2996256-1-git-send-email-arnd-r2nGTMty4D4@public.gmane.org>
2016-04-28 10:52 ` Stefan Berger
2016-04-29 18:42 ` Jarkko Sakkinen
[not found] ` <20160429184206.GA21071-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-04-29 19:41 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).