From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Cc: Christophe Ricard
<christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org,
jean-luc.blanc-qxv4g6HH51o@public.gmane.org,
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
christophe-h.ricard-qxv4g6HH51o@public.gmane.org,
Peter Huewe <peter.huewe-d0qZbvYSIPpWk0Htik3J/w@public.gmane.org>,
benoit.houyere-qxv4g6HH51o@public.gmane.org
Subject: Re: [PATCH v6 6/8] tpm/tpm_tis: Split tpm_tis driver into a core and TCG TIS compliant phy
Date: Mon, 2 May 2016 23:30:19 +0300 [thread overview]
Message-ID: <20160502203019.GA4496@intel.com> (raw)
In-Reply-To: <20160502172552.GA32096-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
On Mon, May 02, 2016 at 11:25:52AM -0600, Jason Gunthorpe wrote:
> On Mon, May 02, 2016 at 08:16:50PM +0300, Jarkko Sakkinen wrote:
> > On Sat, Apr 23, 2016 at 12:11:23AM +0200, Christophe Ricard wrote:
> > > To avoid code duplication between the old tpm_tis and the new and future
> > > native tcg tis driver(ie: spi, i2c...), the tpm_tis driver was reworked,
> > > so that all common logic is extracted and can be reused from all drivers.
> > >
> > > The core methods can also be used from other TIS like drivers.
> > >
> > > itpm workaround is now managed with a specific tis flag
> > > TPM_TIS_ITPM_POSSIBLE.
> >
> > Please drop this patch and add private functions for your SPI driver.
> > This just grows the patch set size and does not add value.
>
> ? If you drop this then you might as well discard the entire series.
>
> It seems there is alot of code overlap, so this seems like a good
> idea.
Oops! The comment was for 7/8.
> Jason
/Jarkko
------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
next prev parent reply other threads:[~2016-05-02 20:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 22:11 [PATCH v6 0/8] Rework of tpm_tis to share common logic accross phy's (lpc/spi/-i2c-) Christophe Ricard
[not found] ` <1461363085-9908-1-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-04-22 22:11 ` [PATCH v6 1/8] tpm: Add include guards in tpm.h Christophe Ricard
2016-04-22 22:11 ` [PATCH v6 2/8] tpm: tpm_tis: Share common data between phys Christophe Ricard
2016-04-22 22:11 ` [PATCH v6 3/8] tpm_tis: Introduce intermediate layer for TPM access Christophe Ricard
2016-04-22 22:11 ` [PATCH v6 4/8] devicetree: Add infineon to vendor-prefix.txt Christophe Ricard
2016-04-22 22:11 ` [PATCH v6 5/8] devicetree: Add Trusted Computing Group " Christophe Ricard
2016-04-22 22:11 ` [PATCH v6 6/8] tpm/tpm_tis: Split tpm_tis driver into a core and TCG TIS compliant phy Christophe Ricard
[not found] ` <1461363085-9908-7-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-05-02 17:16 ` Jarkko Sakkinen
[not found] ` <20160502171650.GC1764-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-05-02 17:25 ` Jason Gunthorpe
[not found] ` <20160502172552.GA32096-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-05-02 20:30 ` Jarkko Sakkinen [this message]
2016-04-22 22:11 ` [PATCH v6 7/8] tpm: Use read/write_bytes for drivers without more specialized methods Christophe Ricard
[not found] ` <1461363085-9908-8-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-05-02 20:32 ` Jarkko Sakkinen
[not found] ` <20160502203236.GA5415-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-05-03 20:28 ` Christophe Ricard
[not found] ` <57290A08.20403-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-05-04 10:52 ` Jarkko Sakkinen
2016-04-22 22:11 ` [PATCH v6 8/8] tpm/tpm_tis_spi: Add support for spi phy Christophe Ricard
2016-04-25 9:12 ` [PATCH v6 0/8] Rework of tpm_tis to share common logic accross phy's (lpc/spi/-i2c-) Jarkko Sakkinen
2016-05-02 22:18 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160502203019.GA4496@intel.com \
--to=jarkko.sakkinen-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org \
--cc=benoit.houyere-qxv4g6HH51o@public.gmane.org \
--cc=christophe-h.ricard-qxv4g6HH51o@public.gmane.org \
--cc=christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jean-luc.blanc-qxv4g6HH51o@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=peter.huewe-d0qZbvYSIPpWk0Htik3J/w@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).