From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: andrew.zamansky@nuvoton.com, tpmdd-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH v2] tpm: Factor out common startup code
Date: Tue, 17 May 2016 10:53:04 -0600 [thread overview]
Message-ID: <20160517165304.GA19976@obsidianresearch.com> (raw)
In-Reply-To: <20160517041557.GA29299@intel.com>
On Tue, May 17, 2016 at 07:15:57AM +0300, Jarkko Sakkinen wrote:
> On Mon, May 16, 2016 at 12:25:47PM -0600, Jason Gunthorpe wrote:
> > Provide some flags in tpm_class_ops to allow drivers to opt-in to the
> > common startup sequence. This is the sequence used by tpm_tis and
> > tpm_crb.
> >
> > All drivers should set this flag.
>
> The commit message should be a much much more verbose I cannot include
> this without a better explanation. Please update this for the next
> revision.
What more description do you want to see?
> > + if (chip->ops->flags & TPM_OPS_PROBE_TPM2) {
> > + rc = tpm2_probe(chip);
> > + if (rc)
> > + return rc;
> > + }
>
> Dead code.
Yes, this is used by the follow on driver updates. Andrew is going to
be sending a patch that uses it right away. I don't really care if it
gets shifted to that patch or not..
Jason
next prev parent reply other threads:[~2016-05-17 16:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 18:25 [PATCH v2] tpm: Factor out common startup code Jason Gunthorpe
2016-05-17 4:15 ` Jarkko Sakkinen
2016-05-17 16:53 ` Jason Gunthorpe [this message]
[not found] ` <20160517165304.GA19976-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-05-18 9:59 ` Jarkko Sakkinen
[not found] ` <20160518095924.GA7177-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-05-18 17:13 ` Jason Gunthorpe
[not found] ` <20160518171320.GA15170-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-05-19 9:07 ` Jarkko Sakkinen
[not found] ` <1463423147-9874-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-05-26 12:23 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160517165304.GA19976@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=andrew.zamansky@nuvoton.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).