tpmdd-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Ed Swierk <eswierk@skyportsystems.com>
Cc: tpmdd-devel@lists.sourceforge.net, stefanb@us.ibm.com,
	linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	jgunthorpe@obsidianresearch.com
Subject: Re: [PATCH v6 4/5] tpm: Allow TPM chip drivers to override reported command durations
Date: Thu, 16 Jun 2016 22:26:41 +0200	[thread overview]
Message-ID: <20160616202641.GC1414@intel.com> (raw)
In-Reply-To: <1465610107-87762-5-git-send-email-eswierk@skyportsystems.com>

On Fri, Jun 10, 2016 at 06:55:06PM -0700, Ed Swierk wrote:
> Some TPM chips report bogus command durations in their capabilities,
> just as others report incorrect timeouts. Rework tpm_get_timeouts() to
> allow chip drivers to override either via a single callback. Also
> clean up handling of TPMs that report milliseconds instead of
> microseconds.
> 
> Signed-off-by: Ed Swierk <eswierk@skyportsystems.com>

Again, LGTM but have to test :)

> ---
>  drivers/char/tpm/tpm-interface.c | 139 +++++++++++++++++++++------------------
>  drivers/char/tpm/tpm_tis.c       |  35 +++-------
>  include/linux/tpm.h              |   3 +-
>  3 files changed, 85 insertions(+), 92 deletions(-)

/Jarkko

  reply	other threads:[~2016-06-16 20:26 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-08  0:45 [PATCH v4 0/4] tpm: Command duration logging and chip-specific override Ed Swierk
     [not found] ` <1465346740-60120-1-git-send-email-eswierk-FilZDy9cOaHkQYj/0HfcvtBPR1lH4CV8@public.gmane.org>
2016-06-08  0:45   ` [PATCH v4 1/4] tpm_tis: Improve reporting of IO errors Ed Swierk
2016-06-08  0:45   ` [PATCH v4 2/4] tpm: Add optional logging of TPM command durations Ed Swierk
2016-06-08  0:45   ` [PATCH v4 3/4] tpm: Allow TPM chip drivers to override reported " Ed Swierk
     [not found]     ` <1465346740-60120-4-git-send-email-eswierk-FilZDy9cOaHkQYj/0HfcvtBPR1lH4CV8@public.gmane.org>
2016-06-08 19:05       ` Jason Gunthorpe
2016-06-08 20:41         ` [tpmdd-devel] " Ed Swierk
2016-06-08  0:45   ` [PATCH v4 4/4] tpm_tis: Increase ST19NP18 TPM command duration to avoid chip lockup Ed Swierk
2016-06-08 23:00   ` [PATCH v5 0/4] tpm: Command duration logging and chip-specific override Ed Swierk
     [not found]     ` <1465426818-89356-1-git-send-email-eswierk-FilZDy9cOaHkQYj/0HfcvtBPR1lH4CV8@public.gmane.org>
2016-06-08 23:00       ` [PATCH v5 1/4] tpm_tis: Improve reporting of IO errors Ed Swierk
2016-06-08 23:00       ` [PATCH v5 2/4] tpm: Add optional logging of TPM command durations Ed Swierk
2016-06-08 23:00       ` [PATCH v5 3/4] tpm: Allow TPM chip drivers to override reported " Ed Swierk
2016-06-10 12:19         ` Jarkko Sakkinen
2016-06-10 17:34           ` Ed Swierk
     [not found]             ` <CAO_EM_m_GsEVUcoUxb8Cg7-46W-mm9CY8PG6J=ZtYuTENrDm9A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-10 19:42               ` Jarkko Sakkinen
     [not found]                 ` <20160610194248.GA7011-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-06-11  1:54                   ` Ed Swierk
2016-06-08 23:00       ` [PATCH v5 4/4] tpm_tis: Increase ST19NP18 TPM command duration to avoid chip lockup Ed Swierk
2016-06-11  1:55       ` [PATCH v6 0/5] tpm: Command duration logging and chip-specific override Ed Swierk
     [not found]         ` <1465610107-87762-1-git-send-email-eswierk-FilZDy9cOaHkQYj/0HfcvtBPR1lH4CV8@public.gmane.org>
2016-06-11  1:55           ` [PATCH v6 1/5] tpm_tis: Improve reporting of IO errors Ed Swierk
2016-06-11  1:55           ` [PATCH v6 2/5] tpm: Add optional logging of TPM command durations Ed Swierk
2016-06-11  1:55           ` [PATCH v6 3/5] tpm: Factor out reading of timeout and duration capabilities Ed Swierk
     [not found]             ` <1465610107-87762-4-git-send-email-eswierk-FilZDy9cOaHkQYj/0HfcvtBPR1lH4CV8@public.gmane.org>
2016-06-16 20:20               ` Jarkko Sakkinen
2016-06-19 12:12               ` Jarkko Sakkinen
     [not found]                 ` <20160619120157.GA29626-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-06-21  1:46                   ` Ed Swierk
2016-06-11  1:55           ` [PATCH v6 4/5] tpm: Allow TPM chip drivers to override reported command durations Ed Swierk
2016-06-16 20:26             ` Jarkko Sakkinen [this message]
2016-06-11  1:55           ` [PATCH v6 5/5] tpm_tis: Increase ST19NP18 TPM command duration to avoid chip lockup Ed Swierk
2016-06-21  1:53           ` [PATCH v7 0/5] tpm: Command duration logging and chip-specific override Ed Swierk
     [not found]             ` <1466474042-110773-1-git-send-email-eswierk-FilZDy9cOaHkQYj/0HfcvtBPR1lH4CV8@public.gmane.org>
2016-06-21  1:53               ` [PATCH v7 1/5] tpm_tis: Improve reporting of IO errors Ed Swierk
2016-06-21  1:53               ` [PATCH v7 2/5] tpm: Add optional logging of TPM command durations Ed Swierk
2016-06-21  1:54               ` [PATCH v7 3/5] tpm: Clean up reading of timeout and duration capabilities Ed Swierk
     [not found]                 ` <1466474042-110773-4-git-send-email-eswierk-FilZDy9cOaHkQYj/0HfcvtBPR1lH4CV8@public.gmane.org>
2016-06-21 20:52                   ` Jarkko Sakkinen
2016-06-22  0:21                   ` Ed Swierk
     [not found]                     ` <CAO_EM_kFH+qO9P0b6dPOvYEGyPTq=3iGR8jVoDChtr6bB51Hzg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-22 10:46                       ` Jarkko Sakkinen
2016-06-21  1:54               ` [PATCH v7 4/5] tpm: Allow TPM chip drivers to override reported command durations Ed Swierk
     [not found]                 ` <1466474042-110773-5-git-send-email-eswierk-FilZDy9cOaHkQYj/0HfcvtBPR1lH4CV8@public.gmane.org>
2016-06-21 20:54                   ` Jarkko Sakkinen
2016-06-21  1:54               ` [PATCH v7 5/5] tpm_tis: Increase ST19NP18 TPM command duration to avoid chip lockup Ed Swierk
     [not found]                 ` <1466474042-110773-6-git-send-email-eswierk-FilZDy9cOaHkQYj/0HfcvtBPR1lH4CV8@public.gmane.org>
2016-06-21 20:55                   ` Jarkko Sakkinen
2016-06-22  1:10               ` [PATCH v8 0/5] tpm: Command duration logging and chip-specific override Ed Swierk
     [not found]                 ` <1466557831-113440-1-git-send-email-eswierk-FilZDy9cOaHkQYj/0HfcvtBPR1lH4CV8@public.gmane.org>
2016-06-22  1:10                   ` [PATCH v8 1/5] tpm_tis: Improve reporting of IO errors Ed Swierk
     [not found]                     ` <1466557831-113440-2-git-send-email-eswierk-FilZDy9cOaHkQYj/0HfcvtBPR1lH4CV8@public.gmane.org>
2016-06-24 18:25                       ` Jason Gunthorpe
2016-06-24 20:21                         ` Jarkko Sakkinen
2016-06-24 20:23                           ` Jarkko Sakkinen
     [not found]                           ` <20160624202131.GB8399-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-06-24 20:26                             ` Jason Gunthorpe
     [not found]                               ` <20160624202615.GA2968-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-06-25 15:24                                 ` Jarkko Sakkinen
     [not found]                                   ` <20160625152430.GA14567-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-06-25 15:47                                     ` Jarkko Sakkinen
     [not found]                                       ` <20160625154745.GA24538-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-06-27 17:55                                         ` Jason Gunthorpe
2016-06-22  1:10                   ` [PATCH v8 2/5] tpm: Add optional logging of TPM command durations Ed Swierk
     [not found]                     ` <1466557831-113440-3-git-send-email-eswierk-FilZDy9cOaHkQYj/0HfcvtBPR1lH4CV8@public.gmane.org>
2016-06-24 18:27                       ` Jason Gunthorpe
     [not found]                         ` <20160624182727.GD14506-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-06-24 20:24                           ` Jarkko Sakkinen
2016-06-22  1:10                   ` [PATCH v8 3/5] tpm: Clean up reading of timeout and duration capabilities Ed Swierk
2016-06-22  1:10                   ` [PATCH v8 4/5] tpm: Allow TPM chip drivers to override reported command durations Ed Swierk
2016-06-22  1:10                   ` [PATCH v8 5/5] tpm_tis: Increase ST19NP18 TPM command duration to avoid chip lockup Ed Swierk
2016-07-13 16:19                 ` [PATCH v9 0/5] tpm: Command duration logging and chip-specific override Ed Swierk
2016-07-13 16:19                   ` [PATCH v9 1/5] tpm_tis: Improve reporting of IO errors Ed Swierk
2016-07-13 16:19                   ` [PATCH v9 2/5] tpm: Add optional logging of TPM command durations Ed Swierk
2016-07-13 16:19                   ` [PATCH v9 3/5] tpm: Clean up reading of timeout and duration capabilities Ed Swierk
2016-07-18 18:15                     ` Jarkko Sakkinen
     [not found]                     ` <1468426776-42762-4-git-send-email-eswierk-FilZDy9cOaHkQYj/0HfcvtBPR1lH4CV8@public.gmane.org>
2016-07-18 18:19                       ` Jarkko Sakkinen
     [not found]                         ` <20160718181953.GE31463-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-07-18 18:20                           ` Jarkko Sakkinen
2016-07-13 16:19                   ` [PATCH v9 4/5] tpm: Allow TPM chip drivers to override reported command durations Ed Swierk
2016-07-13 17:04                     ` kbuild test robot
     [not found]                     ` <1468426776-42762-5-git-send-email-eswierk-FilZDy9cOaHkQYj/0HfcvtBPR1lH4CV8@public.gmane.org>
2016-07-18 18:40                       ` Jarkko Sakkinen
2016-07-13 16:19                   ` [PATCH v9 5/5] tpm_tis: Increase ST19NP18 TPM command duration to avoid chip lockup Ed Swierk
2016-07-13 16:44                   ` [PATCH v9 0/5] tpm: Command duration logging and chip-specific override Ed Swierk
     [not found]                     ` <CAO_EM_mpkeiC1psOYWz8RWsuJFR9HAQ7u5AH5qzSzR=VQ_jTPw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-13 17:36                       ` Jason Gunthorpe
     [not found]                         ` <20160713173613.GD19657-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-07-13 20:00                           ` Ed Swierk
2016-07-13 20:58                             ` Eric W. Biederman
2016-07-13 20:59                             ` Jason Gunthorpe
     [not found]                   ` <1468426776-42762-1-git-send-email-eswierk-FilZDy9cOaHkQYj/0HfcvtBPR1lH4CV8@public.gmane.org>
2016-07-18 18:07                     ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160616202641.GC1414@intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=eswierk@skyportsystems.com \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=stefanb@us.ibm.com \
    --cc=tpmdd-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).