From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Sudip Mukherjee
<sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] tpm: use devm_add_action_or_reset
Date: Mon, 27 Jun 2016 17:04:45 +0300 [thread overview]
Message-ID: <20160627140445.GA1233@intel.com> (raw)
In-Reply-To: <20160616202823.GE1414-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Thu, Jun 16, 2016 at 10:28:23PM +0200, Jarkko Sakkinen wrote:
> On Sun, Jun 12, 2016 at 03:05:29PM +0100, Sudip Mukherjee wrote:
> > If devm_add_action() fails we are explicitly calling put_device() to
> > free the resources allocated. Lets use the helper
> > devm_add_action_or_reset() and return directly in case of error, as we
> > know that the cleanup function has been already called by the helper if
> > there was any error.
> >
> > Signed-off-by: Sudip Mukherjee <sudip.mukherjee-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Applied to master.
/Jarkko
------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape
next prev parent reply other threads:[~2016-06-27 14:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-12 14:05 [PATCH] tpm: use devm_add_action_or_reset Sudip Mukherjee
2016-06-16 20:28 ` Jarkko Sakkinen
[not found] ` <20160616202823.GE1414-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-06-27 14:04 ` Jarkko Sakkinen [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-04-25 20:46 Sudip Mukherjee
[not found] ` <1461617198-32351-1-git-send-email-sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-04-25 20:57 ` Jason Gunthorpe
2016-04-26 8:30 ` Jarkko Sakkinen
2016-04-30 17:00 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160627140445.GA1233@intel.com \
--to=jarkko.sakkinen-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).