(no subject)

(no subject)

[Jason Gunthorpe]

Bcc: 
Subject: Re: [PATCH 2/2 v3] tpm: Add TPM 2.0 support to the Nuvoton i2c
 driver (NPCT6xx family)
Reply-To: 
In-Reply-To: <1467174493-4190-3-git-send-email-andrew.zamansky-KrzQf0k3Iz9BDgjK7y7TUQ@public.gmane.org>

On Wed, Jun 29, 2016 at 07:28:13AM +0300, andrew zamansky wrote:
> -	chip->flags |= TPM_CHIP_FLAG_IRQ;
> +	if (client->irq)
> +		chip->flags |= TPM_CHIP_FLAG_IRQ;
> +

Oh.. this should be a seperate patch, it is a bug fix for the stuff
Jarkko just sent a pull request for:

commit 570a36097f302c0bae4fb5478f1287b9b3626155
Author: Christophe Ricard <christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date:   Thu Mar 31 22:56:56 2016 +0200

    tpm: drop 'irq' from struct tpm_vendor_specific

Jason

------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape

(no subject)

[Alex Gershgorin]

[-- Attachment #1.1: Type: text/plain, Size: 1511 bytes --]

Hi everyone,

Our company use Atmel TPM AT97SC3205 - SPI interface.
Accordingly to datasheests it's compliant to Trusted Computing Group (TCG) Trusted Platform Module TPM) Version 1.2 Specification. Compliant with TCG PC Client-Specific TPM Interface Specification (TIS Version 1.3).
On my target board I'm running Kernel from git://git.infradead.org/users/jjs/linux-tpmdd.git   next head.
I have made some additional changes on my Device Tree.

spi1: spi@fc000000 {
                pinctrl-names = "default";
                pinctrl-0 = <&pinctrl_spi1_default>;
                status = "okay";

                tpm_tis@0 {
                            compatible = "tcg,tpm_tis-spi";
                    reg = <0>;
                            spi-max-frequency = <10000000>;
                    };
            };

This is part of my kernel boot messages:
atmel_spi fc000000.spi: version: 0x311
atmel_spi fc000000.spi: Using dma0chan2 (tx) and dma0chan3 (rx) for DMA transfers
atmel_spi fc000000.spi: Using FIFO (16 data)
atmel_spi fc000000.spi: Atmel SPI Controller at 0xfc000000 (irq 36)
tpm tpm0: tpm_transmit: tpm_send: error -5
tpm_tis_spi: probe of spi32765.0 failed with error -5

I verified with an oscilloscope that all SPI bus signals are in order.

Following the above kernel boot messages - my question is :
    Can I use tpm_tis_spi device driver for AT97SC3205 device ?

Please advise and help with any directions.

Thanks in advance,
Alex Gershgorin






[-- Attachment #1.2: Type: text/html, Size: 3231 bytes --]

[-- Attachment #2: Type: text/plain, Size: 424 bytes --]

------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity 
planning reports. http://sdm.link/zohodev2dev

[-- Attachment #3: Type: text/plain, Size: 192 bytes --]

_______________________________________________
tpmdd-devel mailing list
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/tpmdd-devel

Re: (no subject)

[Jarkko Sakkinen]

On Tue, Jul 19, 2016 at 08:34:20AM +0000, Alex Gershgorin wrote:
>    Hi everyone,
> 
>    Our company use Atmel TPM AT97SC3205 - SPI interface.
>    Accordingly to datasheests it's compliant to Trusted Computing Group (TCG)
>    Trusted Platform Module TPM) Version 1.2 Specification. Compliant with TCG
>    PC Client-Specific TPM Interface Specification (TIS Version 1.3).
>    On my target board I'm running Kernel from
>    git://git.infradead.org/users/jjs/linux-tpmdd.git   next head.
>    I have made some additional changes on my Device Tree.


Are you sure that it uses SPI hardware protocol and not TCG MMIO?
On PC the tranport could be LPC or SPI but the interface is TCG
one.

/Jarkko


>    spi1: spi@fc000000 {
>                    pinctrl-names = "default";
>                    pinctrl-0 = <&pinctrl_spi1_default>;
>                    status = "okay";
> 
>                    tpm_tis@0 {
>                                compatible = "tcg,tpm_tis-spi";
>                        reg = <0>;
>                                spi-max-frequency = <10000000>;
>                        };
>                };
> 
>    This is part of my kernel boot messages:
>    atmel_spi fc000000.spi: version: 0x311
>    atmel_spi fc000000.spi: Using dma0chan2 (tx) and dma0chan3 (rx) for DMA
>    transfers
>    atmel_spi fc000000.spi: Using FIFO (16 data)
>    atmel_spi fc000000.spi: Atmel SPI Controller at 0xfc000000 (irq 36)
>    tpm tpm0: tpm_transmit: tpm_send: error -5
>    tpm_tis_spi: probe of spi32765.0 failed with error -5
> 
>    I verified with an oscilloscope that all SPI bus signals are in order.
> 
>    Following the above kernel boot messages - my question is :
>        Can I use tpm_tis_spi device driver for AT97SC3205 device ?
> 
>    Please advise and help with any directions.
> 
>    Thanks in advance,
>    Alex Gershgorin

> ------------------------------------------------------------------------------
> What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
> patterns at an interface-level. Reveals which users, apps, and protocols are 
> consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
> J-Flow, sFlow and other flows. Make informed decisions using capacity 
> planning reports. http://sdm.link/zohodev2dev

> _______________________________________________
> tpmdd-devel mailing list
> tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/tpmdd-devel


------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity 
planning reports. http://sdm.link/zohodev2dev