From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
linux-security-module@vger.kernel.org,
Stefan Berger <stefanb@linux.vnet.ibm.com>,
Marcel Selhorst <tpmdd@selhorst.net>,
"moderated list:TPM DEVICE DRIVER"
<tpmdd-devel@lists.sourceforge.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 3/5] tpm: replace tpm_gen_interrupt() with tpm_tis_gen_interrupt()
Date: Wed, 20 Jul 2016 23:54:10 +0300 [thread overview]
Message-ID: <20160720205410.GB6525@intel.com> (raw)
In-Reply-To: <20160720170624.GE21460@obsidianresearch.com>
On Wed, Jul 20, 2016 at 11:06:24AM -0600, Jason Gunthorpe wrote:
> On Wed, Jul 20, 2016 at 02:44:58AM +0300, Jarkko Sakkinen wrote:
> > Since tpm_gen_interrupt() is only used in tpm_tis_core.c this commit
> > replaces it with an internal tpm_tis_gen_interrupt(). The semantics
> > also changed in a way that on a system error the driver initialization
> > is failed.
>
> All the patches look good to me now..
>
> Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Thanks.
/Jarkko
next prev parent reply other threads:[~2016-07-20 20:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 23:44 [PATCH v4 0/5] Use tpm_transmit_cmd() consistently across kernel call sites Jarkko Sakkinen
[not found] ` <1468971906-6528-1-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-07-19 23:44 ` [PATCH v4 1/5] tpm/st33zp24: Remove useless tpm_gen_interrupt Jarkko Sakkinen
2016-07-19 23:44 ` [PATCH v4 2/5] tpm: remove unnecessary externs from tpm.h Jarkko Sakkinen
2016-07-19 23:44 ` [PATCH v4 3/5] tpm: replace tpm_gen_interrupt() with tpm_tis_gen_interrupt() Jarkko Sakkinen
[not found] ` <1468971906-6528-4-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-07-20 17:06 ` Jason Gunthorpe
2016-07-20 20:54 ` Jarkko Sakkinen [this message]
[not found] ` <20160720205410.GB6525-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-07-20 20:59 ` Jarkko Sakkinen
2016-07-24 6:32 ` kbuild test robot
2016-07-19 23:44 ` [PATCH v4 4/5] tpm: use tpm_transmit_cmd() in tpm2_probe() Jarkko Sakkinen
2016-07-19 23:45 ` [PATCH v4 5/5] tpm: use tpm_pcr_read_dev() in tpm_do_selftest() Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160720205410.GB6525@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=stefanb@linux.vnet.ibm.com \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).