From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Dmitry Torokhov <dtor-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: Christophe Ricard
<christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
smbarber-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH v3 2/2] tpm: add driver for cr50 on SPI
Date: Thu, 28 Jul 2016 17:17:06 -0600 [thread overview]
Message-ID: <20160728231706.GA22087@obsidianresearch.com> (raw)
In-Reply-To: <20160728230141.GC28623@dtor-ws>
On Thu, Jul 28, 2016 at 04:01:41PM -0700, Dmitry Torokhov wrote:
> > + u8 tx_buf[MAX_SPI_FRAMESIZE];
> > + u8 rx_buf[MAX_SPI_FRAMESIZE];
>
> Both of these need to be annotated as "____cacheline_aligned" since we
> eye them for use in DMA transfers.
Huh. That sure looks true to me..
We make that same mistake in all other tpm SPI drivers.
Can someone send a patch please?
Thanks,
Jason
------------------------------------------------------------------------------
next prev parent reply other threads:[~2016-07-28 23:17 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 2:20 [PATCH 0/2] tpm: add driver for cr50 on SPI Andrey Pronin
2016-07-19 12:56 ` Jarkko Sakkinen
[not found] ` <1468549218-19215-1-git-send-email-apronin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-07-15 2:20 ` [PATCH 1/2] tpm: devicetree: document properties for cr50 Andrey Pronin
2016-07-15 4:05 ` Guenter Roeck
[not found] ` <CABXOdTcVcZ10c6uShN2AXUZfOuK=FESeo73Assi0sziMZJ_+Fw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-15 17:31 ` Andrey Pronin
2016-07-15 18:28 ` Guenter Roeck
[not found] ` <1468549218-19215-2-git-send-email-apronin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-07-17 13:28 ` Rob Herring
2016-07-15 2:20 ` [PATCH 2/2] tpm: add driver for cr50 on SPI Andrey Pronin
[not found] ` <1468549218-19215-3-git-send-email-apronin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-07-15 3:32 ` Jason Gunthorpe
[not found] ` <20160715033236.GH9347-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-07-15 3:44 ` Andrey Pronin
2016-07-19 12:55 ` Jarkko Sakkinen
[not found] ` <20160719125527.GB5047-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-07-20 0:24 ` Andrey Pronin
2016-07-20 17:03 ` Jason Gunthorpe
[not found] ` <20160720170336.GC21460-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-07-21 18:10 ` Andrey Pronin
2016-07-21 21:00 ` Jason Gunthorpe
2016-07-15 2:28 ` [PATCH 0/2] " Peter Huewe
2016-07-15 2:50 ` Andrey Pronin
2016-07-15 3:28 ` Jason Gunthorpe
[not found] ` <20160715032814.GG9347-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-07-15 17:15 ` Andrey Pronin
2016-07-20 3:41 ` [PATCH v2 " Andrey Pronin
[not found] ` <cover.1468985673.git.apronin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-07-20 3:41 ` [PATCH v2 1/2] tpm: devicetree: document properties for cr50 Andrey Pronin
2016-07-20 19:03 ` Rob Herring
2016-07-20 19:49 ` Andrey Pronin
2016-07-20 19:54 ` Jason Gunthorpe
[not found] ` <20160720195422.GA30947-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-07-27 21:02 ` Andrey Pronin
2016-07-21 21:03 ` Rob Herring
2016-07-27 21:00 ` Andrey Pronin
2016-07-20 3:41 ` [PATCH v2 2/2] tpm: add driver for cr50 on SPI Andrey Pronin
2016-07-25 17:09 ` [PATCH v2 0/2] " Peter Huewe
2016-07-27 21:12 ` Andrey Pronin
2016-07-28 4:25 ` [PATCH v3 " Andrey Pronin
[not found] ` <1469679917-120240-1-git-send-email-apronin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-07-28 4:25 ` [PATCH v3 1/2] tpm: devicetree: document properties for cr50 Andrey Pronin
2016-07-28 4:25 ` [PATCH v3 2/2] tpm: add driver for cr50 on SPI Andrey Pronin
2016-07-28 23:01 ` Dmitry Torokhov
2016-07-28 23:17 ` Jason Gunthorpe [this message]
[not found] ` <20160728231706.GA22087-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-07-29 3:01 ` Andrey Pronin
2016-07-29 1:55 ` [PATCH v4 0/2] " Andrey Pronin
[not found] ` <1469757314-116169-1-git-send-email-apronin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-07-29 1:55 ` [PATCH v4 1/2] tpm: devicetree: document properties for cr50 Andrey Pronin
[not found] ` <1469757314-116169-2-git-send-email-apronin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-07-29 17:27 ` Jason Gunthorpe
[not found] ` <20160729172752.GA7458-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-07-29 21:42 ` Rob Herring
2016-08-09 10:08 ` Jarkko Sakkinen
2016-07-29 1:55 ` [PATCH v4 2/2] tpm: add driver for cr50 on SPI Andrey Pronin
2016-08-09 10:20 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160728231706.GA22087@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=dtor-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=smbarber-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).