From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH 2/2] TPM2.0:Adds securityfs support for TPM2.0 eventlog Date: Mon, 29 Aug 2016 11:16:39 -0600 Message-ID: <20160829171639.GA18728@obsidianresearch.com> References: <1469774679-25232-1-git-send-email-nayna@linux.vnet.ibm.com> <1469774679-25232-3-git-send-email-nayna@linux.vnet.ibm.com> <20160729171428.GB6331@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Ken Goldman Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Mon, Aug 29, 2016 at 08:52:59AM -0400, Ken Goldman wrote: > On 7/29/2016 1:14 PM, Jason Gunthorpe wrote: > > > > The bios log is defined to be host endian? > > > > Please reference the standard in a comment that these structs are > > coming from. > > The BIOS log is little endian. That is, all multi-byte values are > little endian. Examples are the pcrIndex, eventType, and eventSize, > as well as the digest count and hashAlg. > > From the "TCG PC Client Platform Firmware Profile Specification" > > 1.7 Specification Conventions > > 1. All constants and data SHALL be represented as Little Endian format > unless otherwise explicitly stated. Surely all those structs need to be tagged le32/etc then? Jason ------------------------------------------------------------------------------