From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [petr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org: TPM2 erroring-out after tpm: Factor out common startup code] Date: Mon, 29 Aug 2016 23:21:26 +0300 Message-ID: <20160829202126.GA6780@intel.com> References: <20160829200828.GB3201@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160829200828.GB3201-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jason Gunthorpe Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Mon, Aug 29, 2016 at 02:08:28PM -0600, Jason Gunthorpe wrote: > Looks legit to me. I think this is a good change as long as it is sent through the normal process (so that it is available in patchwork). /Jarkko > ----- Forwarded message from Petr Vandrovec ----- > > Date: Sat, 27 Aug 2016 23:44:46 -0700 > From: Petr Vandrovec > To: jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org > Subject: TPM2 erroring-out after tpm: Factor out common startup code > > Hi Jason, > your change cae8b441fc20812d7260dc3b45e05ee98fcfff1b to factor out common > startup code introduced regression in tpm2-cmd :-( Now if firmware does > initialize tpm2 (and so tpm2_do_selftest succeeds), 'TPM self test failed' > error message is still printed, despite 'rc' being zero :-( > > Can you apply something like patch below, and send it to Linus? > > You also probably want to keep warning that TPM was not initialized by > firmware if tpm2-cmd has to perform initialization, as in such case TPM cannot > be used for attestation. > Thanks, > Petr > > > Do not print error message on successful TPM2 selftest > > If TPM2 selftest succeeds, everything is fine, and no error message > should be printed. > > Signed-off-by: Petr Vandrovec > > > diff --git a/drivers/char/tpm/tpm2-cmd.c b/drivers/char/tpm/tpm2-cmd.c > index 08c7e23..f141357 100644 > --- a/drivers/char/tpm/tpm2-cmd.c > +++ b/drivers/char/tpm/tpm2-cmd.c > @@ -957,7 +957,7 @@ int tpm2_auto_startup(struct tpm_chip *chip) > goto out; > > rc = tpm2_do_selftest(chip); > - if (rc != TPM2_RC_INITIALIZE) { > + if (rc && rc != TPM2_RC_INITIALIZE) { > dev_err(&chip->dev, "TPM self test failed\n"); > goto out; > } > > ----- End forwarded message ----- > > -- > Jason Gunthorpe (780)4406067x832 > Chief Technology Officer, Obsidian Research Corp Edmonton, Canada > > ------------------------------------------------------------------------------ > _______________________________________________ > tpmdd-devel mailing list > tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org > https://lists.sourceforge.net/lists/listinfo/tpmdd-devel ------------------------------------------------------------------------------