From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v3 1/7] tpm: Define a generic open() method for ascii & bios measurements. Date: Tue, 30 Aug 2016 11:03:45 -0600 Message-ID: <20160830170345.GA6373@obsidianresearch.com> References: <1472532619-22170-1-git-send-email-nayna@linux.vnet.ibm.com> <1472532619-22170-2-git-send-email-nayna@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1472532619-22170-2-git-send-email-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Nayna Jain Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Tue, Aug 30, 2016 at 12:50:13AM -0400, Nayna Jain wrote: > Open methods for eventlog ascii and binary bios measurements file > operations are very similar. This patch refactors the code into > single open() call by passing seq_operations as i_node->private data. > > Suggested-by: Jason Gunthorpe > Signed-off-by: Nayna Jain Looks basically fine, with Jarkko's comment addressed. I recommend using clang-format when working with the kernel, it makes everything easy. Reviewed-by: Jason Gunthorpe Jason ------------------------------------------------------------------------------