* [PATCH v2] tpm/tpm_tis: remove unused itpm variable
@ 2016-09-07 23:01 Tomas Winkler
[not found] ` <1473289262-9395-1-git-send-email-tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Tomas Winkler @ 2016-09-07 23:01 UTC (permalink / raw)
To: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f, Jason Gunthorpe,
Jarkko Sakkinen
Fixes the warning:
drivers/char/tpm/tpm_tis_core.c:443:7: warning: variable ‘itpm’ set but
not used [-Wunused-but-set-variable]
bool itpm;
^~~~
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
V2: fix typos in the subject
drivers/char/tpm/tpm_tis_core.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
index 236015103164..cf6fd13cd1d1 100644
--- a/drivers/char/tpm/tpm_tis_core.c
+++ b/drivers/char/tpm/tpm_tis_core.c
@@ -440,7 +440,6 @@ static int probe_itpm(struct tpm_chip *chip)
0x00, 0x00, 0x00, 0xf1
};
size_t len = sizeof(cmd_getticks);
- bool itpm;
u16 vendor;
rc = tpm_tis_read16(priv, TPM_DID_VID(0), &vendor);
@@ -451,8 +450,6 @@ static int probe_itpm(struct tpm_chip *chip)
if (vendor != TPM_VID_INTEL)
return 0;
- itpm = false;
-
rc = tpm_tis_send_data(chip, cmd_getticks, len);
if (rc == 0)
goto out;
@@ -460,8 +457,6 @@ static int probe_itpm(struct tpm_chip *chip)
tpm_tis_ready(chip);
release_locality(chip, priv->locality, 0);
- itpm = true;
-
rc = tpm_tis_send_data(chip, cmd_getticks, len);
if (rc == 0) {
dev_info(&chip->dev, "Detected an iTPM.\n");
--
2.7.4
------------------------------------------------------------------------------
_______________________________________________
tpmdd-devel mailing list
tpmdd-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1473289262-9395-1-git-send-email-tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH v2] tpm/tpm_tis: remove unused itpm variable [not found] ` <1473289262-9395-1-git-send-email-tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> @ 2016-09-08 10:15 ` Jarkko Sakkinen [not found] ` <20160908101504.GB3145-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Jarkko Sakkinen @ 2016-09-08 10:15 UTC (permalink / raw) To: Tomas Winkler; +Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f On Thu, Sep 08, 2016 at 02:01:02AM +0300, Tomas Winkler wrote: > Fixes the warning: > drivers/char/tpm/tpm_tis_core.c:443:7: warning: variable ‘itpm’ set but > not used [-Wunused-but-set-variable] > bool itpm; > ^~~~ > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> Acked-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> /Jarkko ------------------------------------------------------------------------------ _______________________________________________ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <20160908101504.GB3145-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH v2] tpm/tpm_tis: remove unused itpm variable [not found] ` <20160908101504.GB3145-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> @ 2016-09-08 13:46 ` Jarkko Sakkinen 0 siblings, 0 replies; 3+ messages in thread From: Jarkko Sakkinen @ 2016-09-08 13:46 UTC (permalink / raw) To: Tomas Winkler; +Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f On Thu, Sep 08, 2016 at 01:15:04PM +0300, Jarkko Sakkinen wrote: > On Thu, Sep 08, 2016 at 02:01:02AM +0300, Tomas Winkler wrote: > > Fixes the warning: > > drivers/char/tpm/tpm_tis_core.c:443:7: warning: variable ‘itpm’ set but > > not used [-Wunused-but-set-variable] > > bool itpm; > > ^~~~ > > > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> > > Acked-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Applied to master. I will include this to my 4.9 pull. /Jarkko ------------------------------------------------------------------------------ _______________________________________________ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-08 13:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-07 23:01 [PATCH v2] tpm/tpm_tis: remove unused itpm variable Tomas Winkler
[not found] ` <1473289262-9395-1-git-send-email-tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-08 10:15 ` Jarkko Sakkinen
[not found] ` <20160908101504.GB3145-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-08 13:46 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).