From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH 1/1] tpm/tpm-dev: fix broken style in copy_from_user Date: Sun, 11 Sep 2016 23:38:49 +0300 Message-ID: <20160911203849.GA26511@intel.com> References: <1473621730-23125-1-git-send-email-tomas.winkler@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1473621730-23125-1-git-send-email-tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Tomas Winkler Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Sun, Sep 11, 2016 at 10:22:10PM +0300, Tomas Winkler wrote: > Straighten unneeded line brake and drop useless cast to void. > > Signed-off-by: Tomas Winkler Thanks. Acked-by: Jarkko Sakkinen /Jarkko > --- > drivers/char/tpm/tpm-dev.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/char/tpm/tpm-dev.c b/drivers/char/tpm/tpm-dev.c > index 912ad30be585..9782df406345 100644 > --- a/drivers/char/tpm/tpm-dev.c > +++ b/drivers/char/tpm/tpm-dev.c > @@ -130,8 +130,7 @@ static ssize_t tpm_write(struct file *file, const char __user *buf, > > mutex_lock(&priv->buffer_mutex); > > - if (copy_from_user > - (priv->data_buffer, (void __user *) buf, in_size)) { > + if (copy_from_user(priv->data_buffer, buf, in_size)) { > mutex_unlock(&priv->buffer_mutex); > return -EFAULT; > } > -- > 2.7.4 > ------------------------------------------------------------------------------