From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Tomas Winkler <tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH v2 1/4] tpm/tpm_crb: implement tpm crb idle state
Date: Mon, 12 Sep 2016 11:37:37 -0600 [thread overview]
Message-ID: <20160912173737.GB5843@obsidianresearch.com> (raw)
In-Reply-To: <1473670501-29281-2-git-send-email-tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Mon, Sep 12, 2016 at 11:54:58AM +0300, Tomas Winkler wrote:
> The register TPM_CRB_CTRL_REQ_x contains bits goIdle and cmdReady for
> SW to indicate that the device can enter or should exit the idle state.
>
> The legacy ACPI-start (SMI + DMA) based devices do not support these
> bits and the idle state management is not exposed to the host SW.
> Thus, this functionality only is enabled only for a CRB start (MMIO)
> based devices.
>
> Based on Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> oringal patch:
> 'tpm_crb: implement power tpm crb power management'
>
> Signed-off-by: Tomas Winkler <tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> V2: do not export the functions via tpm ops
You need to restructure this series, do not implement functions that
are not used in a patch.
> +static int __maybe_unused crb_go_idle(struct device *dev, struct crb_priv *priv)
.. and then don't hide the warnings with maybe_unused :(
Jason
------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity
planning reports. http://sdm.link/zohodev2dev
next prev parent reply other threads:[~2016-09-12 17:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 8:54 [PATCH 0/4 V2] tpm/tpm_crb: implement power management Tomas Winkler
[not found] ` <1473670501-29281-1-git-send-email-tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-12 8:54 ` [PATCH v2 1/4] tpm/tpm_crb: implement tpm crb idle state Tomas Winkler
[not found] ` <1473670501-29281-2-git-send-email-tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-12 12:01 ` Jarkko Sakkinen
[not found] ` <20160912120109.GA957-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-12 12:25 ` Winkler, Tomas
[not found] ` <5B8DA87D05A7694D9FA63FD143655C1B542CDCB7-Jy8z56yoSI8MvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-09-12 17:39 ` Jason Gunthorpe
[not found] ` <20160912173902.GC5843-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-12 20:17 ` Jarkko Sakkinen
[not found] ` <20160912201703.GC8889-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-12 20:34 ` Winkler, Tomas
2016-09-14 16:05 ` Jarkko Sakkinen
2016-09-12 13:32 ` Jarkko Sakkinen
[not found] ` <20160912133206.GE957-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-12 13:34 ` Winkler, Tomas
2016-09-12 17:37 ` Jason Gunthorpe [this message]
[not found] ` <20160912173737.GB5843-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-12 20:26 ` Winkler, Tomas
[not found] ` <5B8DA87D05A7694D9FA63FD143655C1B542CDF84-Jy8z56yoSI8MvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-09-12 20:44 ` Jason Gunthorpe
[not found] ` <20160912204449.GA8241-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-12 20:58 ` Winkler, Tomas
2016-09-12 8:54 ` [PATCH v2 2/4] tmp/tpm_crb: fix Intel PTT hw bug during " Tomas Winkler
2016-09-12 8:55 ` [PATCH v2 3/4] tpm/tpm_crb: open code the crb_init into acpi_add Tomas Winkler
[not found] ` <1473670501-29281-4-git-send-email-tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-12 17:41 ` Jason Gunthorpe
[not found] ` <20160912174137.GD5843-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-12 20:46 ` Winkler, Tomas
2016-09-12 8:55 ` [PATCH v2 4/4] tmp/tpm_crb: implement runtime pm for tpm_crb Tomas Winkler
[not found] ` <1473670501-29281-5-git-send-email-tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-12 13:06 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160912173737.GB5843@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).