From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Stefan Berger <stefanb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: "moderated list:TPM DEVICE DRIVER"
<tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: 4b68112 causes 'Could not get TPM timeouts anddurations'
Date: Mon, 12 Sep 2016 22:20:01 +0300 [thread overview]
Message-ID: <20160912192001.GB17314@intel.com> (raw)
In-Reply-To: <20160912191331.GA17314-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Mon, Sep 12, 2016 at 10:13:31PM +0300, Jarkko Sakkinen wrote:
> On Mon, Sep 12, 2016 at 11:59:49AM -0400, Stefan Berger wrote:
> > Stefan Berger/Watson/IBM@IBMUS wrote on 09/12/2016 11:15:34 AM:
> >
> > >
> > > Patch 4b68112 seems like an unlikely candidate for such a failure,
> > > nevertheless that's what I am seeing: 'Could not get TPM timeouts
> > > and durations'.
> >
> > Actually, the patch seems to be quite broken. tpm_cmd is being read from
> > after calling tpm1_getcap_cmd(), but tpm_cmd is not passed to that
> > function, so it wasn't touched. I am not sure how this was intended to
> > work and where the check for the returned size was going to be done.
>
> I will drop this commit. My bad. I looked my only test machine with
> TPM 1.x and the commit was not applied in the test kernel.
>
> I'll resend this after the pull request after I've done proper testing.
> Can you check it out then?
It's now dropped from the master branch. Can you check that things
work for you before I send the pull request? Thank you for reporting
this and sorry for the inconvience.
/Jarkko
------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity
planning reports. http://sdm.link/zohodev2dev
prev parent reply other threads:[~2016-09-12 19:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 15:15 4b68112 causes 'Could not get TPM timeouts and durations' Stefan Berger
[not found] ` <OF8C8919AB.C1A2AE5E-ON0025802C.005396B8-8525802C.0053E181-8eTO7WVQ4XIsd+ienQ86orlN3bxYEBpz@public.gmane.org>
2016-09-12 15:59 ` 4b68112 causes 'Could not get TPM timeouts anddurations' Stefan Berger
[not found] ` <OF094E5F6F.9F1CCCDF-ON0025802C.0056E42F-8525802C.0057EE5F-8eTO7WVQ4XIsd+ienQ86orlN3bxYEBpz@public.gmane.org>
2016-09-12 19:13 ` Jarkko Sakkinen
[not found] ` <20160912191331.GA17314-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-12 19:20 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160912192001.GB17314@intel.com \
--to=jarkko.sakkinen-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=stefanb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).