4b68112 causes 'Could not get TPM timeouts and durations'

4b68112 causes 'Could not get TPM timeouts and durations'

[Stefan Berger]

[-- Attachment #1.1: Type: text/plain, Size: 172 bytes --]

Patch 4b68112 seems like an unlikely candidate for such a failure, 
nevertheless that's what I am seeing: 'Could not get TPM timeouts and 
durations'.

    Stefan



[-- Attachment #1.2: Type: text/html, Size: 262 bytes --]

[-- Attachment #2: Type: text/plain, Size: 79 bytes --]

------------------------------------------------------------------------------

[-- Attachment #3: Type: text/plain, Size: 192 bytes --]

_______________________________________________
tpmdd-devel mailing list
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/tpmdd-devel

Re: 4b68112 causes 'Could not get TPM timeouts anddurations'

[Stefan Berger]

[-- Attachment #1.1: Type: text/plain, Size: 522 bytes --]

Stefan Berger/Watson/IBM@IBMUS wrote on 09/12/2016 11:15:34 AM:

> 
> Patch 4b68112 seems like an unlikely candidate for such a failure, 
> nevertheless that's what I am seeing: 'Could not get TPM timeouts 
> and durations'.

Actually, the patch seems to be quite broken. tpm_cmd is being read from 
after calling tpm1_getcap_cmd(), but tpm_cmd is not passed to that 
function, so it wasn't touched. I am not sure how this was intended to 
work and where the check for the returned size was going to be done.


[-- Attachment #1.2: Type: text/html, Size: 607 bytes --]

[-- Attachment #2: Type: text/plain, Size: 424 bytes --]

------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity 
planning reports. http://sdm.link/zohodev2dev

[-- Attachment #3: Type: text/plain, Size: 192 bytes --]

_______________________________________________
tpmdd-devel mailing list
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/tpmdd-devel

Re: 4b68112 causes 'Could not get TPM timeouts anddurations'

[Jarkko Sakkinen]

On Mon, Sep 12, 2016 at 11:59:49AM -0400, Stefan Berger wrote:
>    Stefan Berger/Watson/IBM@IBMUS wrote on 09/12/2016 11:15:34 AM:
> 
>    >
>    > Patch 4b68112 seems like an unlikely candidate for such a failure,
>    > nevertheless that's what I am seeing: 'Could not get TPM timeouts
>    > and durations'.
> 
>    Actually, the patch seems to be quite broken. tpm_cmd is being read from
>    after calling tpm1_getcap_cmd(), but tpm_cmd is not passed to that
>    function, so it wasn't touched. I am not sure how this was intended to
>    work and where the check for the returned size was going to be done.

I will drop this commit. My bad. I looked my only test machine with
TPM 1.x and the commit was not applied in the test kernel.

I'll resend this after the pull request after I've done proper testing.
Can you check it out then?

Thanks.

/Jarkko

------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity 
planning reports. http://sdm.link/zohodev2dev

Re: 4b68112 causes 'Could not get TPM timeouts anddurations'

[Jarkko Sakkinen]

On Mon, Sep 12, 2016 at 10:13:31PM +0300, Jarkko Sakkinen wrote:
> On Mon, Sep 12, 2016 at 11:59:49AM -0400, Stefan Berger wrote:
> >    Stefan Berger/Watson/IBM@IBMUS wrote on 09/12/2016 11:15:34 AM:
> > 
> >    >
> >    > Patch 4b68112 seems like an unlikely candidate for such a failure,
> >    > nevertheless that's what I am seeing: 'Could not get TPM timeouts
> >    > and durations'.
> > 
> >    Actually, the patch seems to be quite broken. tpm_cmd is being read from
> >    after calling tpm1_getcap_cmd(), but tpm_cmd is not passed to that
> >    function, so it wasn't touched. I am not sure how this was intended to
> >    work and where the check for the returned size was going to be done.
> 
> I will drop this commit. My bad. I looked my only test machine with
> TPM 1.x and the commit was not applied in the test kernel.
> 
> I'll resend this after the pull request after I've done proper testing.
> Can you check it out then?

It's now dropped from the master branch. Can you check that things
work for you before I send the pull request? Thank you for reporting
this and sorry for the inconvience.

/Jarkko

------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity 
planning reports. http://sdm.link/zohodev2dev