From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Ed Swierk <eswierk@skyportsystems.com>,
Marcel Selhorst <tpmdd@selhorst.net>,
"moderated list:TPM DEVICE DRIVER"
<tpmdd-devel@lists.sourceforge.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] tpm: Clean up reading of timeout and duration capabilities
Date: Mon, 19 Sep 2016 17:24:06 -0600 [thread overview]
Message-ID: <20160919232406.GE22760@obsidianresearch.com> (raw)
In-Reply-To: <1474316530-17315-2-git-send-email-jarkko.sakkinen@linux.intel.com>
On Mon, Sep 19, 2016 at 11:22:08PM +0300, Jarkko Sakkinen wrote:
> From: Ed Swierk <eswierk@skyportsystems.com>
>
> Call tpm_getcap() from tpm_get_timeouts() to eliminate redundant
> code. Return all errors to the caller rather than swallowing them
> (e.g. when tpm_transmit_cmd() returns nonzero).
I didn't look at these closely, but I agree with the idea.
Jason
next prev parent reply other threads:[~2016-09-19 23:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 20:22 [PATCH 0/2] fix bad constant expressions in tpm.h Jarkko Sakkinen
[not found] ` <1474316530-17315-1-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-09-19 20:22 ` [PATCH 1/2] tpm: Clean up reading of timeout and duration capabilities Jarkko Sakkinen
2016-09-19 23:24 ` Jason Gunthorpe [this message]
2016-10-21 20:33 ` Jarkko Sakkinen
2016-10-21 20:35 ` Jarkko Sakkinen
2016-09-19 20:22 ` [PATCH 2/2] tpm: fix bad constant expressions Jarkko Sakkinen
[not found] ` <1474316530-17315-3-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-09-20 7:08 ` Winkler, Tomas
2016-09-20 9:56 ` [tpmdd-devel] " Jarkko Sakkinen
2016-09-20 9:57 ` Winkler, Tomas
2016-09-20 12:03 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919232406.GE22760@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=eswierk@skyportsystems.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).