From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: "Winkler, Tomas" <tomas.winkler@intel.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
"moderated list:TPM DEVICE DRIVER"
<tpmdd-devel@lists.sourceforge.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [tpmdd-devel] [PATCH 2/2] tpm: fix bad constant expressions
Date: Tue, 20 Sep 2016 15:03:49 +0300 [thread overview]
Message-ID: <20160920120349.GA30749@intel.com> (raw)
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B542EBC24@hasmsx108.ger.corp.intel.com>
On Tue, Sep 20, 2016 at 09:57:48AM +0000, Winkler, Tomas wrote:
>
> > On Tue, Sep 20, 2016 at 07:08:40AM +0000, Winkler, Tomas wrote:
> > >
> > > > -----Original Message-----
> > > > From: Jarkko Sakkinen [mailto:jarkko.sakkinen@linux.intel.com]
> > > > Sent: Monday, September 19, 2016 23:22
> > > > To: Peter Huewe <peterhuewe@gmx.de>
> > > > Cc: moderated list:TPM DEVICE DRIVER <tpmdd-
> > > > devel@lists.sourceforge.net>; open list
> > > > <linux-kernel@vger.kernel.org>
> > > > Subject: [tpmdd-devel] [PATCH 2/2] tpm: fix bad constant expressions
> > > >
> > > > Sparse reports "bad constant expression" for the use of cpu_to_be32
> > > > inside enums tpm_capabilities and tpm_sub_capabilities. Even though
> > > > it is probably expanded to a constant expression, it is probably cleaner
> > not to use it there.
> > >
> > >
> > > Swap macros were rewritten due to possible compiler bug
> > > https://lkml.org/lkml/2016/5/2/597
> > > And the warning is actually a bug in sparse, it fails to detect constant
> > expression now.
> >
> > I still think that these must be change in order to have some consistency in
> > the subsystem. Now there are two differing conventions.
>
> Nothing against the convention just the commit message is misleading
> in that sense. Tomas
Right. I can edit it to say that "sanitize the constant declarations" or
something like that.
/Jarkko
prev parent reply other threads:[~2016-09-20 12:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 20:22 [PATCH 0/2] fix bad constant expressions in tpm.h Jarkko Sakkinen
[not found] ` <1474316530-17315-1-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-09-19 20:22 ` [PATCH 1/2] tpm: Clean up reading of timeout and duration capabilities Jarkko Sakkinen
2016-09-19 23:24 ` Jason Gunthorpe
2016-10-21 20:33 ` Jarkko Sakkinen
2016-10-21 20:35 ` Jarkko Sakkinen
2016-09-19 20:22 ` [PATCH 2/2] tpm: fix bad constant expressions Jarkko Sakkinen
[not found] ` <1474316530-17315-3-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-09-20 7:08 ` Winkler, Tomas
2016-09-20 9:56 ` [tpmdd-devel] " Jarkko Sakkinen
2016-09-20 9:57 ` Winkler, Tomas
2016-09-20 12:03 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920120349.GA30749@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tomas.winkler@intel.com \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).