From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: Possible issue with tpm_crb runtime PM Date: Thu, 22 Sep 2016 18:51:40 +0300 Message-ID: <20160922155140.GA28886@intel.com> References: <20160920131522.GA950@intel.com> <5B8DA87D05A7694D9FA63FD143655C1B542EBE42@hasmsx108.ger.corp.intel.com> <20160920174712.GA12175@intel.com> <5B8DA87D05A7694D9FA63FD143655C1B542EC0CB@hasmsx108.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B542EC0CB-Jy8z56yoSI8MvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: "Winkler, Tomas" Cc: "tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" List-Id: tpmdd-devel@lists.sourceforge.net On Tue, Sep 20, 2016 at 07:26:08PM +0000, Winkler, Tomas wrote: > > On Tue, Sep 20, 2016 at 01:30:58PM +0000, Winkler, Tomas wrote: > > > > > > > > > > > Hi > > > > > > > > I get this (probably every time) when I do rmmod: > > > > > > > > [ 4372.725616] tpm tpm0: A TPM error (325) occurred stopping the TPM > > > > > > > > That is probably caused by failing TPM2_Shutdown. My guess is that > > > > runtime PM patches cause this. > > > > > > > > I'll verify that the problem does not occur with the next branch, > > > > which does not include runtime PM patches. > > > > > > Can you produce the full log? > > > > I just compiled kernel from the 'next' branch and it doesn't have this issue. If > > you want, I can recompile the kernel but that's the only error message that is > > emitted and it is obviously emitted by tpm2_shutdown(). > > This is a Skylake m7-6Y75 machine that I use for ad-hoc testing (runs Ubuntu > > 16.04 LTS, usually I test kernel with buildroot initramfs) of TPM and SGX. > > If you can just revert the last patch, so the device will be always up, see if this helps? This error does not occur with 0c22db435bf7 ("tpm/tpm_crb: open code the crb_init into acpi_add") /Jarkko ------------------------------------------------------------------------------