From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Nayna Jain <nayna@linux.vnet.ibm.com>,
Marcel Selhorst <tpmdd@selhorst.net>,
"moderated list:TPM DEVICE DRIVER"
<tpmdd-devel@lists.sourceforge.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] tpm: replace dynamically allocated bios_dir with a static array
Date: Sat, 1 Oct 2016 22:22:07 +0300 [thread overview]
Message-ID: <20161001192207.GA31992@intel.com> (raw)
In-Reply-To: <20161001164932.GA13462@obsidianresearch.com>
On Sat, Oct 01, 2016 at 10:49:32AM -0600, Jason Gunthorpe wrote:
> On Sat, Oct 01, 2016 at 03:41:17PM +0300, Jarkko Sakkinen wrote:
> > - bin_file =
> > + chip->bios_dir[cnt] =
> > securityfs_create_file("binary_bios_measurements",
> > - S_IRUSR | S_IRGRP, tpm_dir,
> > + S_IRUSR | S_IRGRP, chip->bios_dir[cnt],
>
> That is certainly not right, Nayna's version was correct, the function
> argument is the directory to create under and bios_dir[0] is setup as the
> directory for tpm. This is also why removal is done in reverse order,
> files are removed then the directory that contains them.
Right. I overlooked this.
> Jason
/Jarkko
next prev parent reply other threads:[~2016-10-01 19:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-01 12:41 [PATCH 0/2] Clean up handling of event log files Jarkko Sakkinen
[not found] ` <1475325678-16573-1-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-10-01 12:41 ` [PATCH 1/2] tpm: define a generic open() method for ascii & bios measurements Jarkko Sakkinen
2016-10-01 12:41 ` [PATCH 2/2] tpm: replace dynamically allocated bios_dir with a static array Jarkko Sakkinen
2016-10-01 16:49 ` Jason Gunthorpe
2016-10-01 19:22 ` Jarkko Sakkinen [this message]
2016-10-01 12:44 ` [PATCH 0/2] Clean up handling of event log files Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161001192207.GA31992@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nayna@linux.vnet.ibm.com \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).