From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v4 3/8] tpm: validate event log access before tpm_bios_log_setup Date: Sun, 9 Oct 2016 17:25:44 -0600 Message-ID: <20161009232544.GC24139@obsidianresearch.com> References: <1475051682-23060-1-git-send-email-nayna@linux.vnet.ibm.com> <1475051682-23060-4-git-send-email-nayna@linux.vnet.ibm.com> <20161003171419.GE6801@obsidianresearch.com> <57F9C4C4.2070508@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <57F9C4C4.2070508-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Nayna Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Sun, Oct 09, 2016 at 09:47:08AM +0530, Nayna wrote: > >>+ const struct tpm_securityfs_data *sfs_data = > >>+ (const struct tpm_securityfs_data *)inode->i_private; > >>+ const struct seq_operations *seqops = sfs_data->seqops; > > > >You need a get_device(&chip->dev) here, and the matching put_device in fops->release(). > > > >>+ seq->private = sfs_data->log; > > > >So store the chip here > Sorry, I think I didn't understand the purpose of storing chip here. Since we need to do get_device in open() you need to do put_device in release() How will you reliably do put_device if you do not store chip in the seq_private? Jason ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot