From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH RESEND 2/3] tpm: replace dynamically allocated bios_dir with a static array Date: Tue, 11 Oct 2016 21:09:32 +0300 Message-ID: <20161011180932.GA6900@intel.com> References: <1475349926-476-1-git-send-email-jarkko.sakkinen@linux.intel.com> <1475349926-476-3-git-send-email-jarkko.sakkinen@linux.intel.com> <57FBE39B.2030301@linux.vnet.ibm.com> <20161011112315.GB21688@intel.com> <20161011165355.GB6881@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20161011165355.GB6881-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jason Gunthorpe Cc: "moderated list:TPM DEVICE DRIVER" , open list List-Id: tpmdd-devel@lists.sourceforge.net On Tue, Oct 11, 2016 at 10:53:55AM -0600, Jason Gunthorpe wrote: > On Tue, Oct 11, 2016 at 02:23:15PM +0300, Jarkko Sakkinen wrote: > > > >+ chip->bios_dir[cnt] = > > > > securityfs_create_file("ascii_bios_measurements", > > > >- S_IRUSR | S_IRGRP, tpm_dir, > > > >+ S_IRUSR | S_IRGRP, chip->bios_dir[0], > > > > (void *)&tpm_ascii_b_measurments_seqops, > > > > &tpm_bios_measurements_ops); > > > > >+ if (is_bad(chip->bios_dir[cnt])) > > > >+ goto err; > > > > >+err: > > > >+ chip->bios_dir[cnt] = NULL; > > > > > > The updated patch looks fine. > > > Just, I am not sure if NULL assignment is needed. > > > > It's not needed. > > It is required to switch an ERR_PTR to NULL, see is_bad() > > The original version that used a counter in chip did not need it. Oops, sorry. I added it back. Thanks for pointing this out. > Jason /Jarkko ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot