tpmdd-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Jarkko Sakkinen
	<jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: g@intel.com,
	"moderated list:TPM DEVICE DRIVER"
	<tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 1/3] tpm_crb: map locality registers
Date: Tue, 11 Oct 2016 12:29:22 -0600	[thread overview]
Message-ID: <20161011182922.GB20253@obsidianresearch.com> (raw)
In-Reply-To: <20161011182100.GC6900-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

On Tue, Oct 11, 2016 at 09:21:00PM +0300, Jarkko Sakkinen wrote:
> On Tue, Oct 11, 2016 at 11:01:43AM -0600, Jason Gunthorpe wrote:
> > On Tue, Oct 11, 2016 at 12:23:04PM +0300, Jarkko Sakkinen wrote:
> > > In order to provide access to locality registers, this commits adds
> > > mapping of the head of the CRB registers, which are located right
> > > before the control area.
> > 
> > I think you should squash this into the prior patch, no sense in
> > changing all these lines twice
> > 
> > But looks better to me.
> 
> So... do you suggest to squash with request/reliquish locality stuff?
> Just checking because this is 1/3 :)

Hm, maybe my mailer went wrong, but I saw the original patch right
before this one.. Never mind

Jason

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot

  parent reply	other threads:[~2016-10-11 18:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-11  9:23 [PATCH 0/3] Locality support for the CRB driver Jarkko Sakkinen
     [not found] ` <1476177787-15003-1-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-10-11  9:23   ` [PATCH RFC 1/3] tpm_crb: expand struct crb_control_area to struct crb_regs Jarkko Sakkinen
2016-10-11  9:23   ` [PATCH 1/3] tpm_crb: map locality registers Jarkko Sakkinen
     [not found]     ` <1476177787-15003-3-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-10-11 11:25       ` Jarkko Sakkinen
2016-10-11 17:01       ` Jason Gunthorpe
     [not found]         ` <20161011170143.GC6881-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-10-11 18:21           ` Jarkko Sakkinen
     [not found]             ` <20161011182100.GC6900-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-11 18:29               ` Jason Gunthorpe [this message]
     [not found]                 ` <20161011182922.GB20253-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-10-11 19:48                   ` Jarkko Sakkinen
2016-10-11  9:23   ` [PATCH 2/3] tpm_crb: encapsulate crb_wait_for_reg_32 Jarkko Sakkinen
     [not found]     ` <1476177787-15003-4-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-10-11 10:21       ` Winkler, Tomas
     [not found]         ` <5B8DA87D05A7694D9FA63FD143655C1B542F7FD8-Jy8z56yoSI8MvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-10-11 11:29           ` Jarkko Sakkinen
2016-10-11  9:23   ` [PATCH 3/3] tpm_crb: request and relinquish locality 0 Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161011182922.GB20253@obsidianresearch.com \
    --to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
    --cc=g@intel.com \
    --cc=jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).