From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH 2/3] tpm xen: Remove bogus tpm_chip_unregister Date: Wed, 2 Nov 2016 04:30:30 -0600 Message-ID: <20161102103030.llb45xwnnlwokotm@intel.com> References: <1477520926-32594-1-git-send-email-jgunthorpe@obsidianresearch.com> <1477520926-32594-2-git-send-email-jgunthorpe@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1477520926-32594-2-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jason Gunthorpe Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Wed, Oct 26, 2016 at 04:28:45PM -0600, Jason Gunthorpe wrote: > tpm_chip_unregister can only be called after tpm_chip_register. > devm manages the allocation so no unwind is needed here. > > Fixes: afb5abc262e96 ("tpm: two-phase chip management functions") Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Reviewed-by: Jarkko Sakkinen /Jarkko > --- > drivers/char/tpm/xen-tpmfront.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c > index 62028f483bba..a2ab00831df1 100644 > --- a/drivers/char/tpm/xen-tpmfront.c > +++ b/drivers/char/tpm/xen-tpmfront.c > @@ -307,7 +307,6 @@ static int tpmfront_probe(struct xenbus_device *dev, > rv = setup_ring(dev, priv); > if (rv) { > chip = dev_get_drvdata(&dev->dev); > - tpm_chip_unregister(chip); > ring_free(priv); > return rv; > } > -- > 2.1.4 > ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi