From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH] tpm: drop chip->is_open and chip->duration_adjusted Date: Tue, 15 Nov 2016 22:28:32 -0700 Message-ID: <20161116052832.GB6044@obsidianresearch.com> References: <20161114234500.24839-1-jarkko.sakkinen@linux.intel.com> <20161115043001.GA22482@obsidianresearch.com> <20161115051106.u2xoduwf2kpcznv3@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20161115051106.u2xoduwf2kpcznv3@intel.com> Sender: owner-linux-security-module@vger.kernel.org To: Jarkko Sakkinen Cc: tpmdd-devel@lists.sourceforge.net, linux-security-module@vger.kernel.org, Peter Huewe , Marcel Selhorst , Christophe Ricard , open list List-Id: tpmdd-devel@lists.sourceforge.net On Mon, Nov 14, 2016 at 09:11:54PM -0800, Jarkko Sakkinen wrote: > How strong is your opposition here? I do not see any exceptional damage > done but see some subtle but still significant benefits. It seems OK, but I never like seeing locking made less clear - this should be manageable, and there isn't a performance concern with tpm either.. Jason