From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH] tpm: Check the bios_dir entry for NULL before accessing it Date: Wed, 16 Nov 2016 14:08:54 -0800 Message-ID: <20161116220854.4yrr7rajc2hhs6yw@intel.com> References: <1479304573-13601-1-git-send-email-stefanb@linux.vnet.ibm.com> <20161116203853.GA22708@obsidianresearch.com> <20161116220633.yfvpnvps3e222527@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20161116220633.yfvpnvps3e222527-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jason Gunthorpe Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Wed, Nov 16, 2016 at 02:06:33PM -0800, Jarkko Sakkinen wrote: > On Wed, Nov 16, 2016 at 01:38:53PM -0700, Jason Gunthorpe wrote: > > On Wed, Nov 16, 2016 at 08:56:13AM -0500, Stefan Berger wrote: > > > Check the bios_dir entry for NULL before accessing it. Currently > > > this crashes the driver when a TPM 2 is attached and the entries > > > are NULL. > > > > Yep > > > > > for (i = (TPM_NUM_EVENT_LOG_FILES - 1); i >= 0; i--) { > > > - inode = d_inode(chip->bios_dir[i]); > > > - inode_lock(inode); > > > - inode->i_private = NULL; > > > - inode_unlock(inode); > > > - securityfs_remove(chip->bios_dir[i]); > > > + if (chip->bios_dir[i]) { > > > > Nope, this must be is_err_or_null, we store err ptrs in this array. > > " > err: > chip->bios_dir[cnt] = NULL; > " > > There is assignment to NULL so this should be fine. Applied. Not yet squashed. I'll save that for the next week and possible other squashes to the point when I prepare the pull request. /Jarkko ------------------------------------------------------------------------------