From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH 2/2] tpm: Fix error code handling after tpm_bios_log_setup Date: Mon, 21 Nov 2016 13:37:08 -0700 Message-ID: <20161121203708.GA7294@obsidianresearch.com> References: <1479429004-7962-1-git-send-email-stefanb@linux.vnet.ibm.com> <1479429004-7962-2-git-send-email-stefanb@linux.vnet.ibm.com> <20161118155249.sdxp2qfjfzfw4tzt@intel.com> <20161119182228.GA22775@obsidianresearch.com> <20161120121451.awcraondhcvzpbig@intel.com> <20161121175520.GA24191@obsidianresearch.com> <20161121203244.iwx2wa2zcilqd5ao@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20161121203244.iwx2wa2zcilqd5ao@intel.com> Sender: owner-linux-security-module@vger.kernel.org To: Jarkko Sakkinen Cc: Stefan Berger , tpmdd-devel@lists.sourceforge.net, linux-security-module@vger.kernel.org, Nayna List-Id: tpmdd-devel@lists.sourceforge.net On Mon, Nov 21, 2016 at 10:32:44PM +0200, Jarkko Sakkinen wrote: > > And this one fixes the sysfs problem > > > > https://patchwork.kernel.org/patch/9438331/ > > > > Here is a commit message: > > > > tpm: Do not call tpm_chip_unregister if register has not succeeded > > > > This is no longer allowed, vtpm was relying on the check inside the > > tpm core which was removed. Fixes an oops during error unwind. > > > > Fixes: a8ed92219a04 ("tpm: Get rid of TPM_CHIP_FLAG_REGISTERED") > > Signed-off-by: Jason Gunthorpe > > Tested-by: Stefan Berger > > > > That just leaves the ACPI thing.. > > I like the original commit message more. It documents the change. ?? This is for https://patchwork.kernel.org/patch/9438331/ which didn't have a message yet. Jason