Re: [PATCH 2/2] tpm: Fix error code handling after tpm_bios_log_setup

[Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>]

On Mon, Nov 21, 2016 at 01:37:08PM -0700, Jason Gunthorpe wrote:
> On Mon, Nov 21, 2016 at 10:32:44PM +0200, Jarkko Sakkinen wrote:
> 
> > > And this one fixes the sysfs problem
> > > 
> > > https://patchwork.kernel.org/patch/9438331/
> > > 
> > > Here is a commit message:
> > > 
> > > tpm: Do not call tpm_chip_unregister if register has not succeeded
> > > 
> > > This is no longer allowed, vtpm was relying on the check inside the
> > > tpm core which was removed. Fixes an oops during error unwind.
> > > 
> > > Fixes: a8ed92219a04 ("tpm: Get rid of TPM_CHIP_FLAG_REGISTERED")
> > > Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
> > > Tested-by: Stefan Berger <stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
> > > 
> > > That just leaves the ACPI thing..
> > 
> > I like the original commit message more. It documents the change.
> 
> ??
> 
> This is for  https://patchwork.kernel.org/patch/9438331/ which didn't
> have a message yet.

This was the commit message when I did git am:

    tpm: vtpm_proxy: Do not access host's event log
    
    On Thu, Nov 17, 2016 at 06:15:20PM -0500, Stefan Berger wrote:
    
    > >>Further, I had the impression that the error unwinding following -ENODEV has
    > >>an issue related to sysfs.
    > >I don't follow this comment..
    >
    > I have encountered this error here, which gets masked when applying the
    > previously shown patch.
    
    If tpm_chip_register fails vtpm must not call tpm_chip_unregister:
    
    > [   58.271017]  [<ffffffff8155bd32>] dpm_sysfs_remove+0x22/0x60
    > [   58.271017]  [<ffffffff8154e438>] device_del+0x58/0x280
    > [   58.271017]  [<ffffffffa024c020>] tpm_chip_unregister+0x40/0xb0 [tpm]
    > [   58.271017]  [<ffffffffa0292360>] vtpm_proxy_fops_release+0x40/0x60 [tpm_vtpm_proxy]
    
    So, this is a vtpm thing I missed for 'tpm: Get rid of TPM_CHIP_FLAG_REGISTERED'
    
    Does this do the trick?

/Jarkko

------------------------------------------------------------------------------