From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Jarkko Sakkinen
<jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH v6 4/9] tpm: drop tpm1_chip_register(/unregister)
Date: Tue, 22 Nov 2016 09:42:40 -0700 [thread overview]
Message-ID: <20161122164240.GC3956@obsidianresearch.com> (raw)
In-Reply-To: <20161122112200.55khdxtctt5rel4j-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Tue, Nov 22, 2016 at 01:22:00PM +0200, Jarkko Sakkinen wrote:
> On Mon, Nov 14, 2016 at 05:00:51AM -0500, Nayna Jain wrote:
> > Check for TPM2 chip in tpm_sysfs_add_device, tpm_bios_log_setup and
> > tpm_bios_log_teardown in order to make code flow cleaner and to enable
> > to implement TPM 2.0 support later on. This is partially derived from
> > the commit by Nayna Jain with the extension that also tpm1_chip_register
> > is dropped.
> >
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
>
> This commit remains unreviewed and tested. I'm in the author role here
> so I cannot help with this. If that does not happen soon I cannot put
> this into the pull request.
I tested it on my ARM system when I tested your branch.
I think it looks better this way..
Reviewed-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Jason
------------------------------------------------------------------------------
next prev parent reply other threads:[~2016-11-22 16:42 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 10:00 [PATCH v6 0/9] tpm: cleanup/fixes in existing event log support Nayna Jain
2016-11-14 10:00 ` [PATCH v6 2/9] tpm: replace symbolic permission with octal for securityfs files Nayna Jain
[not found] ` <1479117656-12403-3-git-send-email-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-11-14 22:18 ` Jarkko Sakkinen
2016-11-14 22:21 ` Jarkko Sakkinen
[not found] ` <20161114222114.wtk2nypib2o4zfvk-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-11-15 0:11 ` Jarkko Sakkinen
[not found] ` <1479117656-12403-1-git-send-email-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-11-14 10:00 ` [PATCH v6 1/9] tpm: define a generic open() method for ascii & bios measurements Nayna Jain
2016-11-14 10:00 ` [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with a static array Nayna Jain
2016-11-22 11:23 ` Jarkko Sakkinen
[not found] ` <20161122112333.7ootyrbssd6pkrjb-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-11-22 16:58 ` Jason Gunthorpe
[not found] ` <20161122165856.GD3956-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-11-24 13:57 ` Jarkko Sakkinen
[not found] ` <20161124135723.kfafipftppjyr5ip-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-11-24 16:53 ` Jason Gunthorpe
[not found] ` <20161124165313.GB4930-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-11-25 8:08 ` Jarkko Sakkinen
2016-11-25 19:38 ` Jason Gunthorpe
2016-11-26 12:54 ` Jarkko Sakkinen
2016-11-22 19:26 ` Nayna
2016-11-24 14:01 ` Jarkko Sakkinen
2016-11-14 10:00 ` [PATCH v6 4/9] tpm: drop tpm1_chip_register(/unregister) Nayna Jain
2016-11-22 11:22 ` Jarkko Sakkinen
[not found] ` <20161122112200.55khdxtctt5rel4j-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-11-22 16:42 ` Jason Gunthorpe [this message]
[not found] ` <20161122164240.GC3956-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-11-23 18:33 ` Nayna
2016-11-24 11:52 ` Jarkko Sakkinen
2016-11-24 11:51 ` Jarkko Sakkinen
2016-11-14 10:00 ` [PATCH v6 5/9] tpm: have event log use the tpm_chip Nayna Jain
2016-11-14 23:44 ` Jarkko Sakkinen
[not found] ` <20161114234401.dkffb5gcvols4sgb-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-11-15 0:12 ` Jarkko Sakkinen
2016-11-14 10:00 ` [PATCH v6 6/9] tpm: fix the missing .owner in tpm_bios_measurements_ops Nayna Jain
2016-11-14 22:22 ` Jarkko Sakkinen
2016-11-15 0:13 ` Jarkko Sakkinen
2016-11-14 10:00 ` [PATCH v6 7/9] tpm: redefine read_log() to handle ACPI/OF at runtime Nayna Jain
2016-11-15 0:14 ` Jarkko Sakkinen
2016-11-14 10:00 ` [PATCH v6 8/9] tpm: replace of_find_node_by_name() with dev of_node property Nayna Jain
2016-11-14 10:00 ` [PATCH v6 9/9] tpm: cleanup of printk error messages Nayna Jain
[not found] ` <1479117656-12403-10-git-send-email-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-11-14 22:24 ` Jarkko Sakkinen
2016-11-15 0:15 ` Jarkko Sakkinen
2016-11-14 22:33 ` [PATCH v6 0/9] tpm: cleanup/fixes in existing event log support Jarkko Sakkinen
2016-11-15 0:25 ` Jarkko Sakkinen
[not found] ` <20161115002514.qhweuyzg5mgebusq-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-11-15 0:30 ` Jarkko Sakkinen
2016-11-15 2:15 ` Jarkko Sakkinen
[not found] ` <20161115021543.d4wgjqid7fut4y4c-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-11-15 5:35 ` Nayna
2016-11-15 17:40 ` Jarkko Sakkinen
2016-11-15 18:06 ` Jason Gunthorpe
2016-11-15 18:54 ` Jarkko Sakkinen
[not found] ` <20161115185453.e52miq2em7gj4qyi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-11-19 18:36 ` Jason Gunthorpe
2016-11-20 9:58 ` Jarkko Sakkinen
2016-11-21 18:25 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161122164240.GC3956@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).