From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v6 4/9] tpm: drop tpm1_chip_register(/unregister) Date: Tue, 22 Nov 2016 09:42:40 -0700 Message-ID: <20161122164240.GC3956@obsidianresearch.com> References: <1479117656-12403-1-git-send-email-nayna@linux.vnet.ibm.com> <1479117656-12403-5-git-send-email-nayna@linux.vnet.ibm.com> <20161122112200.55khdxtctt5rel4j@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20161122112200.55khdxtctt5rel4j-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jarkko Sakkinen Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Tue, Nov 22, 2016 at 01:22:00PM +0200, Jarkko Sakkinen wrote: > On Mon, Nov 14, 2016 at 05:00:51AM -0500, Nayna Jain wrote: > > Check for TPM2 chip in tpm_sysfs_add_device, tpm_bios_log_setup and > > tpm_bios_log_teardown in order to make code flow cleaner and to enable > > to implement TPM 2.0 support later on. This is partially derived from > > the commit by Nayna Jain with the extension that also tpm1_chip_register > > is dropped. > > > > Signed-off-by: Jarkko Sakkinen > > This commit remains unreviewed and tested. I'm in the author role here > so I cannot help with this. If that does not happen soon I cannot put > this into the pull request. I tested it on my ARM system when I tested your branch. I think it looks better this way.. Reviewed-by: Jason Gunthorpe Jason ------------------------------------------------------------------------------