From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with a static array Date: Thu, 24 Nov 2016 09:53:13 -0700 Message-ID: <20161124165313.GB4930@obsidianresearch.com> References: <1479117656-12403-1-git-send-email-nayna@linux.vnet.ibm.com> <1479117656-12403-4-git-send-email-nayna@linux.vnet.ibm.com> <20161122112333.7ootyrbssd6pkrjb@intel.com> <20161122165856.GD3956@obsidianresearch.com> <20161124135723.kfafipftppjyr5ip@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20161124135723.kfafipftppjyr5ip-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jarkko Sakkinen Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Thu, Nov 24, 2016 at 03:57:23PM +0200, Jarkko Sakkinen wrote: > I manually added the changes to: > > tpm: replace dynamically allocated bios_dir with a static array For this patch.. Could drop 'int rc' from tpm1_chip_register, but it will come back in a later patch Could dump TPM_NUM_EVENT_LOG_FILES and just use ARRAY_SIZE(chip->bios_dir) Now the the stub for tpm_bios_log_setup can properly return -ENODEV This is no good at this point in the series - we need the ENODEV detection in tpm_chip_register() from the 'Fix handle of missing event log' moved into this patch, because it now returns ENODEV due to sercurityfs The commit 'tpm: vtpm_proxy: Do not access host's event log' still needs a proper commit message - it doesn't match what the patch is doing at all. If you are going to be editing the patches I'd suggest squashing all the bug fix ones with proper credit so it at least makes sense to read.. Jason ------------------------------------------------------------------------------