From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Nayna Jain <nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH v5 2/3] tpm: enhance read_log_of() to support Physical TPM event log
Date: Thu, 24 Nov 2016 23:06:37 +0200 [thread overview]
Message-ID: <20161124210637.6dspokalv7tcql26@intel.com> (raw)
In-Reply-To: <1479922057-8752-3-git-send-email-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
On Wed, Nov 23, 2016 at 12:27:36PM -0500, Nayna Jain wrote:
> - memcpy(log->bios_event_log, __va(*basep), *sizep);
> + if (of_property_match_string(np, "compatible", "IBM,vtpm") < 0)
> + memcpy(chip->log.bios_event_log, __va(be64_to_cpup(basep)),
> + log_size);
> + else
> + memcpy(chip->log.bios_event_log, __va(*basep), log_size);
This does not look good. You should be able rearrange your code in a way
that you only have only one memcpy call.
/Jarkko
------------------------------------------------------------------------------
next prev parent reply other threads:[~2016-11-24 21:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 17:27 [PATCH v5 0/3] tpm: securityfs support for TPM 2.0 firmware event log Nayna Jain
2016-11-23 17:27 ` [PATCH v5 1/3] tpm: move event log init functions to tpm_eventlog_init.c Nayna Jain
[not found] ` <1479922057-8752-2-git-send-email-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-11-23 19:38 ` Jason Gunthorpe
[not found] ` <20161123193830.GB13927-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-11-24 8:01 ` Nayna
[not found] ` <58369E3F.40509-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-11-24 16:43 ` Jason Gunthorpe
2016-11-24 16:50 ` Nayna
2016-11-24 21:01 ` Jarkko Sakkinen
[not found] ` <20161124210105.ykmbednlmae52tla-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-11-25 19:43 ` Jason Gunthorpe
[not found] ` <1479922057-8752-1-git-send-email-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-11-23 17:27 ` [PATCH v5 2/3] tpm: enhance read_log_of() to support Physical TPM event log Nayna Jain
[not found] ` <1479922057-8752-3-git-send-email-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-11-23 19:37 ` Jason Gunthorpe
2016-11-24 7:53 ` Nayna
2016-11-24 21:06 ` Jarkko Sakkinen [this message]
2016-11-23 17:27 ` [PATCH v5 3/3] tpm: add securityfs support for TPM 2.0 firmware " Nayna Jain
[not found] ` <1479922057-8752-4-git-send-email-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-11-24 21:10 ` Jarkko Sakkinen
2016-11-25 2:51 ` [tpmdd-devel] " Stefan Berger
2016-11-25 8:11 ` Jarkko Sakkinen
[not found] ` <11f97863-aa40-a9aa-836f-4b446faf1ed3-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-11-26 15:24 ` Jarkko Sakkinen
[not found] ` <20161124211057.xynmfteky5r7uc27-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-11-25 19:43 ` Jason Gunthorpe
2016-11-26 12:59 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161124210637.6dspokalv7tcql26@intel.com \
--to=jarkko.sakkinen-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).