From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
"moderated list:TPM DEVICE DRIVER"
<tpmdd-devel@lists.sourceforge.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] tpm_crb: request and relinquish locality 0
Date: Mon, 5 Dec 2016 09:32:35 -0700 [thread overview]
Message-ID: <20161205163235.GA24852@obsidianresearch.com> (raw)
In-Reply-To: <20161203175213.10210-4-jarkko.sakkinen@linux.intel.com>
On Sat, Dec 03, 2016 at 07:52:13PM +0200, Jarkko Sakkinen wrote:
> + iowrite32(CRB_LOC_CTRL_RELINQUISH, &priv->regs_h->loc_ctrl);
Since regs_h can be null shouldn't there be some guards ?
Jason
next prev parent reply other threads:[~2016-12-05 16:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-03 17:52 [PATCH v2 0/3] Locality support for tpm_crb Jarkko Sakkinen
[not found] ` <20161203175213.10210-1-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-12-03 17:52 ` [PATCH v2 1/3] tpm_crb: map locality registers Jarkko Sakkinen
[not found] ` <20161203175213.10210-2-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-12-03 18:41 ` Jarkko Sakkinen
[not found] ` <20161203184109.u6zok4f4ssbleht4-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-12-05 12:07 ` Winkler, Tomas
[not found] ` <5B8DA87D05A7694D9FA63FD143655C1B54336B91-Jy8z56yoSI8MvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-12-05 12:21 ` Jarkko Sakkinen
2016-12-05 21:31 ` [tpmdd-devel] " Winkler, Tomas
2016-12-06 18:35 ` Jarkko Sakkinen
2016-12-03 17:52 ` [PATCH v2 2/3] tpm_crb: encapsulate crb_wait_for_reg_32 Jarkko Sakkinen
[not found] ` <20161203175213.10210-3-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-12-03 18:41 ` Jarkko Sakkinen
2016-12-05 21:34 ` [tpmdd-devel] " Winkler, Tomas
[not found] ` <5B8DA87D05A7694D9FA63FD143655C1B54336FFE-Jy8z56yoSI8MvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-12-06 18:38 ` Jarkko Sakkinen
2016-12-03 17:52 ` [PATCH v2 3/3] tpm_crb: request and relinquish locality 0 Jarkko Sakkinen
[not found] ` <20161203175213.10210-4-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-12-03 18:42 ` Jarkko Sakkinen
2016-12-05 21:51 ` [tpmdd-devel] " Winkler, Tomas
[not found] ` <5B8DA87D05A7694D9FA63FD143655C1B54337027-Jy8z56yoSI8MvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-12-06 18:41 ` Jarkko Sakkinen
2016-12-05 16:32 ` Jason Gunthorpe [this message]
[not found] ` <20161205163235.GA24852-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-12-06 18:40 ` Jarkko Sakkinen
2016-12-03 18:40 ` [PATCH v2 0/3] Locality support for tpm_crb Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161205163235.GA24852@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).