From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Sonny Rao <sonnyrao-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] tpm: do not suspend/resume if power stays on
Date: Wed, 1 Mar 2017 11:43:33 -0700 [thread overview]
Message-ID: <20170301184333.GA12197@obsidianresearch.com> (raw)
In-Reply-To: <20170301135429.GF28874@leverpostej>
> > +Optional properties:
> > +- powered-while-suspended: present when the TPM is left powered on between
> > + suspend and resume (makes the suspend/resume callbacks do nothing).
>
> This reads like configuration rather than a HW property.
I read this to mean the HW does not cut power to the TPM when Linux
does 'suspend'.
We recently added global suspend/resume callbacks to the TPM
core. Those call backs do not power off the TPM, they just prepare its
internal state to loose power to the chip. Skipping that process on
hardware that does not power-off the TPM makes sense to me.
But, Sonny, perhaps this should be a global flag in tpm_chip, not a
per-interface-driver override?
Jason
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
next prev parent reply other threads:[~2017-03-01 18:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 11:51 [PATCH] tpm: do not suspend/resume if power stays on Enric Balletbo i Serra
[not found] ` <20170301115116.19696-1-enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2017-03-01 12:00 ` Peter Huewe
[not found] ` <EB063F8C-96C0-4584-8C96-9E8F271988FB-Mmb7MZpHnFY@public.gmane.org>
2017-03-01 12:08 ` Enric Balletbo i Serra
2017-03-01 13:54 ` Mark Rutland
2017-03-01 18:43 ` Jason Gunthorpe [this message]
2017-03-01 22:39 ` [tpmdd-devel] " Sonny Rao
[not found] ` <CAPz6YkX=X+mZZRaiYrFGE0qyX1QC=wnXaA-PfvSozwfDM37h1w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-03-01 23:18 ` Jason Gunthorpe
2017-03-02 0:02 ` [tpmdd-devel] " Sonny Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301184333.GA12197@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sonnyrao-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).