From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH v6 1/2] tpm: Issue a TPM2_Shutdown for TPM2 devices. Date: Tue, 20 Jun 2017 00:12:20 +0200 Message-ID: <20170619221220.kfk5dldducxvou5b@linux.intel.com> References: <20170616172531.28464-1-joshz@google.com> <1497828091.2552.6.camel@linux.intel.com> <1497828407.2552.8.camel@linux.intel.com> <20170619155122.GA10188@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20170619155122.GA10188-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jason Gunthorpe Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, jmorris-gx6/JNMH7DfYtjvyW6yDsg@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Mon, Jun 19, 2017 at 09:51:22AM -0600, Jason Gunthorpe wrote: > On Mon, Jun 19, 2017 at 01:26:47AM +0200, Jarkko Sakkinen wrote: > > > Feels weird that you have to call framework functions like that in the > > driver. You must have brilliant reason to do so and that should be very > > well documented in the code. This is terrible... > > This was all discussed on the list. It the way these callbacks work, > the higher levels in the callback stack call the lower levels, this > allows each level the place the next level's callback properly, eg do > things before/after as necessary. > > Jason I tried to look up for discussion from the patchwork. These had appeared in v6. I guess I have to backtrack the discussions from my maidir because I honestly don't understand why class shutdown would have to call bus callback explicitly. There's nothing in the commit message about this nor is there any comment in the code. This must be fairly recent development that I've missed? /Jarkko ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot