From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nayna Subject: Re: [PATCH v2 1/3] TPM2.0: Refactored eventlog init functions. Date: Tue, 16 Aug 2016 14:35:04 +0530 Message-ID: <57B2D740.1010305@linux.vnet.ibm.com> References: <1470771295-15680-1-git-send-email-nayna@linux.vnet.ibm.com> <1470771295-15680-2-git-send-email-nayna@linux.vnet.ibm.com> <20160809222740.GD5535@obsidianresearch.com> <57AB0C14.8080305@linux.vnet.ibm.com> <20160813024540.GB26929@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160813024540.GB26929-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jason Gunthorpe Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net Sure Jason.. Taking care of split and other fixes in my V3 version of patch. Thanks & Regards, - Nayna On 08/13/2016 08:15 AM, Jason Gunthorpe wrote: > On Wed, Aug 10, 2016 at 04:42:20PM +0530, Nayna wrote: >> Thanks for reviewing. >> >> Sure, I will post next version with split as two patches and other fixes as >> suggested. Below is the breakdown of two patches, let me know if this >> doesn't sound ok. >> >> 1. First patch to clean up the code related to tpm_eventlog_init.c - generic >> open() and bios_dir as dentry array. > > Split the patches further. One idea per patch. > >> 2. Second patch to have changes related to using of_node property and struct >> tpm_chip in tpm_of.c. Includes adding CONFIG_OF. > > Yes > >> And one feedback which I didn't understand and so need your help with that >> is >> >>>> -extern struct dentry **tpm_bios_log_setup(const char *); >>>> -extern void tpm_bios_log_teardown(struct dentry **); >>>> +extern void tpm_bios_log_setup(struct tpm_chip *chip); >>>> +extern void tpm_bios_log_teardown(struct tpm_chip *chip); >>> >>> We are trying to get rid of these extra externs.. >> >> This is currently called by tpm_chip_register to setup the bios log. >> So, what did it meant by getting rid of these ? > > The word extern in this context is unnecessary, just drop it when you > edit the line. > > Jason > ------------------------------------------------------------------------------