From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nayna Subject: Re: [PATCH v4 8/8] tpm: add securityfs support for TPM 2.0 firmware event log Date: Tue, 11 Oct 2016 00:24:17 +0530 Message-ID: <57FBE3D9.7010505@linux.vnet.ibm.com> References: <1475051682-23060-1-git-send-email-nayna@linux.vnet.ibm.com> <1475051682-23060-9-git-send-email-nayna@linux.vnet.ibm.com> <20161001115154.GB8664@intel.com> <57F9A52C.7050405@linux.vnet.ibm.com> <20161009091409.GD31891@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20161009091409.GD31891-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jarkko Sakkinen Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On 10/09/2016 02:44 PM, Jarkko Sakkinen wrote: > HI > > On Sun, Oct 09, 2016 at 07:32:20AM +0530, Nayna wrote: >> >> >> On 10/01/2016 05:21 PM, Jarkko Sakkinen wrote: >>> On Wed, Sep 28, 2016 at 04:34:42AM -0400, Nayna Jain wrote: >>>> Unlike the device driver support for TPM 1.2, the TPM 2.0 support >>>> does not create the securityfs pseudo files for displaying the >>>> firmware event log. >>>> >>>> This patch enables support for providing the TPM 2.0 event log in >>>> binary form. TPM 2.0 event log supports a crypto agile format that >>>> records multiple digests, which is different from TPM 1.2. This >>>> patch adds the TPM 2.0 event log parser to understand the crypto >>>> agile format. >>> >>> I'll got through the patch (the split comment is valid) >> >> Sure, will do it. > > Please go through this series and see if they look good to you: > > https://lkml.org/lkml/2016/10/1/121 > > You should have them in your email archive (posted a week ago). I went through this series, looks good to me, just a minor comment on Patch 2/3. Thanks & Regards, - Nayna > > /Jarkko > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot