Re: [PATCH 2/2] tpm: Fix error code handling after tpm_bios_log_setup

[Nayna <nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>]

On 11/18/2016 06:00 AM, Stefan Berger wrote:
> tpm_bios_log_setup() may return -ENODEV in case no log was
> found. In this case we do not need to fail the device.
>
> Signed-off-by: Stefan Berger <stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
> ---
>   drivers/char/tpm/tpm-chip.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c
> index 3f27753..2d6530b 100644
> --- a/drivers/char/tpm/tpm-chip.c
> +++ b/drivers/char/tpm/tpm-chip.c
> @@ -346,7 +346,7 @@ int tpm_chip_register(struct tpm_chip *chip)
>   	tpm_sysfs_add_device(chip);
>
>   	rc = tpm_bios_log_setup(chip);
> -	if (rc == -ENODEV)
> +	if (rc != -ENODEV)
>   		return rc;

This will return even for (rc == 0).

Thanks & Regards,
   - Nayna

>
>   	tpm_add_ppi(chip);
>


------------------------------------------------------------------------------