From: Michael Ellerman <michael@ellerman.id.au>
To: Tommi Rantala <tt.rantala@gmail.com>
Cc: trinity@vger.kernel.org
Subject: Re: [PATCH] Read pid_max from /proc
Date: Mon, 03 Jun 2013 16:12:59 +1000 [thread overview]
Message-ID: <1370239979.21159.3.camel@concordia> (raw)
In-Reply-To: <CA+ydwtoa-VRGoAVURKYT71Zu=DVzB5LmZ9BmjxbKxYQ7J+wAEg@mail.gmail.com>
On Mon, 2013-06-03 at 08:54 +0300, Tommi Rantala wrote:
> 2013/6/3 Michael Ellerman <michael@ellerman.id.au>:
> > I was hitting this on my system, where it's 65536. So fix the todo and
> > read it from /proc.
> >
> > I left a fallback to the hardcoded values in case /proc is not mounted
> > or something else goes wrong.
>
> Looks good to me, but please also fclose() in read_pid_max().
Ah crap, I knew I'd miss something, will resend.
cheers
next prev parent reply other threads:[~2013-06-03 6:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 1:07 [PATCH] Read pid_max from /proc Michael Ellerman
2013-06-03 5:54 ` Tommi Rantala
2013-06-03 6:12 ` Michael Ellerman [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-06-03 13:32 Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370239979.21159.3.camel@concordia \
--to=michael@ellerman.id.au \
--cc=trinity@vger.kernel.org \
--cc=tt.rantala@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox