* [PATCH] Fix logging logic in output().
@ 2016-02-17 16:20 Artem Savkov
2016-02-17 16:55 ` Dave Jones
0 siblings, 1 reply; 2+ messages in thread
From: Artem Savkov @ 2016-02-17 16:20 UTC (permalink / raw)
To: davej; +Cc: trinity, Artem Savkov
Commit "preparation for different forms of logging." contained a typo that
broke logging to mainlogfile.
Signed-off-by: Artem Savkov <asavkov@redhat.com>
---
log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/log.c b/log.c
index dbac844..aee5a67 100644
--- a/log.c
+++ b/log.c
@@ -103,7 +103,7 @@ void output(unsigned char level, const char *fmt, ...)
}
/* go on with file logs only if enabled */
- if (logging == LOGGING_FILES)
+ if (logging == LOGGING_DISABLED)
return;
handle = find_logfile_handle();
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix logging logic in output().
2016-02-17 16:20 [PATCH] Fix logging logic in output() Artem Savkov
@ 2016-02-17 16:55 ` Dave Jones
0 siblings, 0 replies; 2+ messages in thread
From: Dave Jones @ 2016-02-17 16:55 UTC (permalink / raw)
To: Artem Savkov; +Cc: trinity
On Wed, Feb 17, 2016 at 05:20:39PM +0100, Artem Savkov wrote:
> Commit "preparation for different forms of logging." contained a typo that
> broke logging to mainlogfile.
>
> Signed-off-by: Artem Savkov <asavkov@redhat.com>
> ---
> log.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/log.c b/log.c
> index dbac844..aee5a67 100644
> --- a/log.c
> +++ b/log.c
> @@ -103,7 +103,7 @@ void output(unsigned char level, const char *fmt, ...)
> }
>
> /* go on with file logs only if enabled */
> - if (logging == LOGGING_FILES)
> + if (logging == LOGGING_DISABLED)
> return;
Duh, yeah, that's pretty silly. This prep work still hasn't materialised
into other forms of logging, but for now this is the obvious fix.
thanks,
Dave
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-17 16:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-17 16:20 [PATCH] Fix logging logic in output() Artem Savkov
2016-02-17 16:55 ` Dave Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).