From: Dave Jones <davej@redhat.com>
To: Nicolas Kaiser <nikai@nikai.net>
Cc: trinity@vger.kernel.org
Subject: Re: [PATCH] overwritten assignment in sanitise_setsockopt
Date: Tue, 2 Apr 2013 10:15:48 -0400 [thread overview]
Message-ID: <20130402141548.GA1477@redhat.com> (raw)
In-Reply-To: <20130402134003.747af8ed@absol.kitzblitz>
On Tue, Apr 02, 2013 at 01:40:03PM +0200, Nicolas Kaiser wrote:
> I noticed an assignment that gets immediately overwritten, contradicting
> a nearby comment.
> According to the comment, 'optval' should get disabled half of the time.
>
> As at the time of the conditional assignment optval was already set to
> different nonzero values, it looks to me like the trailing assignment,
> which was introduced in commit 737e1a71, may be unintended.
Good catch. Applied.
thanks,
Dave
prev parent reply other threads:[~2013-04-02 14:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 11:40 [PATCH] overwritten assignment in sanitise_setsockopt Nicolas Kaiser
2013-04-02 14:15 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130402141548.GA1477@redhat.com \
--to=davej@redhat.com \
--cc=nikai@nikai.net \
--cc=trinity@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox