trinity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Vince Weaver <vincent.weaver@maine.edu>
Cc: trinity@vger.kernel.org
Subject: Re: [patch] Re: a perf_event_open() update
Date: Tue, 21 May 2013 12:54:59 -0400	[thread overview]
Message-ID: <20130521165459.GB9163@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1305192329560.28551@vincent-weaver-1.um.maine.edu>

On Sun, May 19, 2013 at 11:34:53PM -0400, Vince Weaver wrote:
 > 
 > Here's an updated patch that more or less exercises all of the 
 > perf_event_open() bits, up to around the 3.6 kernel or so.
 > 
 > The patch is standalone against current trinity git.
 > 
 > It could definitely use some review and tuning.
 > 
 > I haven't turned up any issues with it, but that's partly because in my 
 > experience (the recent exploit being an exception) perf_event bugs rarely 
 > manifest with just an open call; they usually involve 
 > reads/writes/ioctls/mmaps/signals on the fd that is opened, as well as 
 > problems after fork/exec or else on complex events made of multiple 
 > perf_event_open() calls chained together (the call can take a previously 
 > opened fd as an argument).  Testing things like this will be more 
 > difficult.

Looks ok to me. I applied it after making some whitespace changes.

thanks,

	Dave

      reply	other threads:[~2013-05-21 16:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-17 15:18 a perf_event_open() update Vince Weaver
2013-05-17 21:20 ` [patch] " Vince Weaver
2013-05-18  1:01 ` Dave Jones
2013-05-20  3:34   ` [patch] " Vince Weaver
2013-05-21 16:54     ` Dave Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130521165459.GB9163@redhat.com \
    --to=davej@redhat.com \
    --cc=trinity@vger.kernel.org \
    --cc=vincent.weaver@maine.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).