From: Nico Golde <nico@ngolde.de>
To: trinity@vger.kernel.org
Subject: Re: minor trinity patch
Date: Fri, 24 May 2013 01:47:12 +0200 [thread overview]
Message-ID: <20130523234712.GS14739@ngolde.de> (raw)
In-Reply-To: <CA+ydwtrggwedMpTeOfbSDAYDT7H=zZU7qAzSs6SzDW1Yx3Gi4g@mail.gmail.com>
Hi,
* Tommi Rantala <tt.rantala@gmail.com> [2013-05-23 20:58]:
> 2013/5/22 Nico Golde <nico@ngolde.de>:
> > I changed the code the following way:
> > @@ -21,7 +22,8 @@ static size_t bldevs, chrdevs, miscdevs;
> > static void parse_proc_devices(void)
> > {
> > FILE *fp;
> > - char *name, *line = NULL;
> > + char *line = NULL;
> > + char name[32];
>
> It would be IMO preferable to not hardcode the max length.
I agree, this is actually left over from quickly changing this.
Are you aware of a proper maximum defined in the kernel headers or do we want to
allocate this completely dynamically?
Cheers
Nico
next prev parent reply other threads:[~2013-05-23 23:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20121220165100.GA8748@ngolde.de>
[not found] ` <20121220171726.GA7543@redhat.com>
[not found] ` <20121220172246.GA16285@ngolde.de>
[not found] ` <20121220172741.GA17760@redhat.com>
[not found] ` <20121220200255.GB16285@ngolde.de>
[not found] ` <20121220201903.GA14944@redhat.com>
2013-05-22 14:14 ` minor trinity patch Nico Golde
2013-05-23 18:58 ` Tommi Rantala
2013-05-23 23:47 ` Nico Golde [this message]
2013-06-03 5:55 ` Tommi Rantala
2013-06-21 13:20 ` Nico Golde
2013-06-24 16:03 ` Nico Golde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130523234712.GS14739@ngolde.de \
--to=nico@ngolde.de \
--cc=trinity@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox